You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sunank200 (via GitHub)" <gi...@apache.org> on 2023/06/13 12:01:21 UTC

[GitHub] [airflow] sunank200 commented on a diff in pull request #31223: add basic openlineage metrics to stats collector

sunank200 commented on code in PR #31223:
URL: https://github.com/apache/airflow/pull/31223#discussion_r1228010490


##########
airflow/providers/openlineage/plugins/adapter.py:
##########
@@ -117,8 +118,10 @@ def emit(self, event: RunEvent):
             self._client = self.get_or_create_openlineage_client()
         event = self._redacter.redact(event, max_depth=20)
         try:
-            return self._client.emit(event)
+            with Stats.timer("ol.emit.attempts"):

Review Comment:
   +1. Test should also include scenario for exception



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org