You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/22 09:43:51 UTC
[GitHub] [camel-k-runtime] nicolaferraro opened a new issue #495: Add support for property mapping in Kamelets
nicolaferraro opened a new issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495
How to deal with components that don't support setting up data (e.g. credentials) in the endpoint URI (e.g. Salesforce)?
Currently a Kamelet can define a flow, but maybe we can let the kamelet define properties in order to deal with these cases.
E.g. the Salesforce kamelet can setup the component properties this way, i.e. by interpolating kamelet properties.
They'll be global, but this is sufficient for the source/sink use case.
Wdyt @lburgazzoli, @davsclaus ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696649638
I guess we should not remove the option to configure at component level but also to provide option to configure things on endpoint level, at the end the goal of a template/kamelet is exactly to hide the complexity.
If we don't want to add such option to the endpoint, that would mean that each template should create its own copy of every component that may be used behind the scenes right ? So if we want to go to that path, we need to provide such support in the template concept.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] davsclaus commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696653407
Yes in theory and no in practice.
Some components that may be internal like seda rely on being a singleton component as it holds the queues etc. So there is no clear line.
Some components rely on the component to handle session management for multiple logins, and others can only do one (JMS can only connect to a single system).
So if you do a kamelet with jms that does
from websphere mq to activemq
then that would need to have jms1 and jms2 components with their own connection factory.
Rewriting the jms component/endpoint to support multiples would be really complex.
Lets revisit this next week after our duties at work this work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] davsclaus commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696647039
You would setup a 2nd component as salesforce2.
what dhiraj would be doing is wrong and would make things complex/worse. You have always had to create a 2nd component, eg jms has the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696703666
I think I could have reasonable solution but will keep it secret till next week to see if it will survive the initial stage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] davsclaus edited a comment on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
davsclaus edited a comment on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696645876
Actually I dont think we can make components to be 100% configurable on endpoint levels. For example JMS you need to setup a connection factory and some other bits which is component level.
I would say kamelets should allow to configure global settings like credentials on a higher level that then become component level configurations, or even something that can configure camel-main/camel-quarkus etc.
eg basically what you can configure with
camel.component.salesforce.xxx = 123
should be something we think into the kamelet concept.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] oscerd commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696643808
We need to go through the camel components and fix all the situation like the Salesforce one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696619161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli closed issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
lburgazzoli closed issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] davsclaus commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696645876
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] davsclaus edited a comment on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
davsclaus edited a comment on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696645876
Actually I dont think we can make components to be 100% configurable on endpoint levels. For example JMS you need to setup a connection factory and some other bits which is component level.
I would say kamelets should allow to configure global settings like credentials on a higher level that then become component level configurations, or even something that can configure camel-main/camel-quarkus etc.
eg basically what you can configure with
camel.component.salesforce.xxx = 123
should be something we think into the kamelet concept.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] davsclaus commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696645876
Actually I dont think we can make components to be 100% configurable on endpoint levels. For example JMS you need to setup a connection factory and some other bits which is component level.
I would say kamelets should allow to configure global settings like credentials on a higher level that then become component level configurations, or even something that can configure camel-main/camel-quarkus etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] davsclaus commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696671908
Yeah we may want to add tenant (or some better term) information on components
- multi tenant (seda, log, file, http)
- single tenant (jms, salesforce, aws)
And then for single tenants we would need to create new distinct components if the kamelet use endpoints from same component that would targeted different systems
Anyway some beer and wine and some good nights sleep and next week we forgot all about this and then we have a fresh perspective to come up with a good solution ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] oscerd commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696643808
We need to go through the camel components and fix all the situation like the Salesforce one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-819430375
This can be solved by https://issues.apache.org/jira/browse/CAMEL-16394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] davsclaus commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696646795
When you start to mess with this like on salesforce then it become more complex to allow to configure on endpoint level and component level. And frankly endpoint level can sometimes become too complex with long uris with many options. And you need to repeat yourself when you use the same component in more endpoints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696619161
IMHO we should fix the component and about the salesforce one, it is being worked by @dhirajsb
The global approach would work for sources and sinks but not for general purpose kamelets as - I don't know how common it is - that approach would fail in a salesforce-to-salesforce use case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696646706
But that would break if you do as example slaesforce-to-salesforce with different credentials
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-847042780
I think that now with the local beans and the kamelet-reify component we have a solution for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #495: Add support for property mapping in Kamelets
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #495:
URL: https://github.com/apache/camel-k-runtime/issues/495#issuecomment-696656313
yeah let revisit it next week
but in general if you have two templates targeting the same jms system (even with the same credentials), then you still need to create two distinct components because you can't derive if they are shared or not from the template context (of course it is not the same for seda)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org