You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/09/21 01:27:02 UTC
[kudu-CR] [java client] Fix an NPE in KuduException
Jean-Daniel Cryans has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4488
Change subject: [java client] Fix an NPE in KuduException
......................................................................
[java client] Fix an NPE in KuduException
Saw this in a Jenkins run and also running ITClient on my machine.
Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4488/1
--
To view, visit http://gerrit.cloudera.org:8080/4488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] [java client] Fix an NPE in KuduException
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4488
to look at the new patch set (#2).
Change subject: [java client] Fix an NPE in KuduException
......................................................................
[java client] Fix an NPE in KuduException
Saw this in a Jenkins run and also running ITClient on my machine.
Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4488/2
--
To view, visit http://gerrit.cloudera.org:8080/4488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] Fix an NPE in KuduException
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [java client] Fix an NPE in KuduException
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4488/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java:
PS1, Line 83: // Message is allowed to be null, so if we let it go through we'll NPE building the Status
: // down the line.
> Nit: second part of the sentence is self-evident. I'd just say "The message
> Where do these null messages come from?
InterruptedException when created via thread.interrupt has a null message. Here's another instance that's less clear:
java.lang.NullPointerException
at org.apache.kudu.WireProtocol$AppStatusPB$Builder.setMessage(WireProtocol.java:847)
at org.apache.kudu.client.Status.<init>(Status.java:43)
at org.apache.kudu.client.Status.<init>(Status.java:52)
at org.apache.kudu.client.Status.IOError(Status.java:128)
at org.apache.kudu.client.KuduException.transformException(KuduException.java:96)
at org.apache.kudu.client.KuduSession.apply(KuduSession.java:88)
at org.apache.kudu.client.ITClient$WriterThread.run(ITClient.java:240)
--
To view, visit http://gerrit.cloudera.org:8080/4488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [java client] Fix an NPE in KuduException
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: [java client] Fix an NPE in KuduException
......................................................................
[java client] Fix an NPE in KuduException
Saw this in a Jenkins run and also running ITClient on my machine.
Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f
Reviewed-on: http://gerrit.cloudera.org:8080/4488
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] Fix an NPE in KuduException
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [java client] Fix an NPE in KuduException
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4488/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java:
PS1, Line 83: // Message is allowed to be null, so if we let it go through we'll NPE building the Status
: // down the line.
Nit: second part of the sentence is self-evident. I'd just say "The message may be null." (since that is surprising).
Where do these null messages come from?
--
To view, visit http://gerrit.cloudera.org:8080/4488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [java client] Fix an NPE in KuduException
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [java client] Fix an NPE in KuduException
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceddc6931e8d3a8cb807657fc5c0804f7052e48f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No