You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:57:02 UTC
[GitHub] [skywalking] kezhenxu94 opened a new issue #5770: [Python] Make the decorator `trace` support `async`, `await` functions
kezhenxu94 opened a new issue #5770:
URL: https://github.com/apache/skywalking/issues/5770
Currently the decorator `@trace` only support plain functions. Decorating functions with `async` makes the trace hierarchy incorrect.
```python
@runnable()
async def test1(self):
return '1'
@runnable()
async def test2(self):
return self.test1()
def test(self):
asyncio.run(self.test2())
```
this generates the trace like this

while expectation is

@taskmgr , if you're interested in this, comment here and I can assign to you, FYI @WillemJiang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #5770: [Python] Make the decorator `trace` support `async`, `await` functions
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #5770:
URL: https://github.com/apache/skywalking/issues/5770#issuecomment-722092293
> I 'd like to do this~
If you need any help, feel free to ping me here or via WeChat direct messages :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] taskmgr commented on issue #5770: [Python] Make the decorator `trace` support `async`, `await` functions
Posted by GitBox <gi...@apache.org>.
taskmgr commented on issue #5770:
URL: https://github.com/apache/skywalking/issues/5770#issuecomment-720901856
I 'd like to do this~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #5770: [Python] Make the decorator `trace` support `async`, `await` functions
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #5770:
URL: https://github.com/apache/skywalking/issues/5770
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org