You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sfirke (via GitHub)" <gi...@apache.org> on 2025/03/13 17:06:16 UTC
[I] Can't upload spreadsheets with capitalized extensions .XLSX and .CSV [superset]
sfirke opened a new issue, #32654:
URL: https://github.com/apache/superset/issues/32654
### Bug description
Running 5.0.0rc1, try to upload a spreadsheet with a capitalized extension and it causes an error:
It's a bummer that I get sent files like this but they are still valid files.
### Screenshots/recordings
### Superset version
master / latest-dev
### Python version
I don't know
### Node version
I don't know
### Browser
Chrome
### Additional context
I think the fix goes here: https://github.com/apache/superset/blob/master/superset-frontend/src/features/databases/UploadDataModel/index.tsx#L186-L187
Have that comparison happen with both the new file and the allow list first converted to lowercase. I can't test it out to send a PR right now, anyone is welcome to pick this up.
### Checklist
- [ ] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [ ] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Can't upload spreadsheets with capitalized extensions .XLSX and .CSV [superset]
Posted by "UncoveredBread (via GitHub)" <gi...@apache.org>.
UncoveredBread commented on issue #32654:
URL: https://github.com/apache/superset/issues/32654#issuecomment-2727854664
Hi! I’m new to open-source and working on this. I’ve updated `validateUploadFileExtension` to be case-insensitive and am testing it now. Hoping to submit a PR soon—any feedback welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Can't upload spreadsheets with capitalized extensions .XLSX and .CSV [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #32654:
URL: https://github.com/apache/superset/issues/32654#issuecomment-2727870728
Hello @UncoveredBread! As you can see above I drafted a PR a few minutes before you posted. I'm glad you're getting involved with Superset; you could take over my PR if you like, feel free to use what I have in your fork & branch. The Korbit.ai bot gave two suggestions on my PR and they're both good, in my opinion, so you could implement those.
Alternatively you could tackle https://github.com/apache/superset/issues/32528 which is another good first issue. Or both! I'll stop working on this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Can't upload spreadsheets with capitalized extensions .XLSX and .CSV [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #32654: Can't upload spreadsheets with capitalized extensions .XLSX and .CSV
URL: https://github.com/apache/superset/issues/32654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Can't upload spreadsheets with capitalized extensions .XLSX and .CSV [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #32654:
URL: https://github.com/apache/superset/issues/32654#issuecomment-2722625098
Who capitalizes their extensions!? SACRILEGE!
Should support it though...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Can't upload spreadsheets with capitalized extensions .XLSX and .CSV [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #32654:
URL: https://github.com/apache/superset/issues/32654#issuecomment-2722107058
It _might_ be as simple as adding entries [here](https://github.com/apache/superset/blob/1b375b715cf844d0cc4b61428a4e63abe0ec7369/superset-frontend/src/features/databases/UploadDataModel/index.tsx#L165) if you want to test it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Can't upload spreadsheets with capitalized extensions .XLSX and .CSV [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #32654:
URL: https://github.com/apache/superset/issues/32654#issuecomment-2722572329
I guess I could add .XLSX, .CSV, capitalized versions of all of them - but if I can make it so file extensions are case-insensitive, that felt like the more "proper" fix...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org