You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sumitagrawl (via GitHub)" <gi...@apache.org> on 2023/04/04 13:27:33 UTC
[GitHub] [ozone] sumitagrawl opened a new pull request, #4533: HDDS-8228. Add metric for out of order/retried delete transactions
sumitagrawl opened a new pull request, #4533:
URL: https://github.com/apache/ozone/pull/4533
## What changes were proposed in this pull request?
- metrics added to count out of order delete transactions received from scm
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8228
## How was this patch tested?
Patch is verified with E2E to check metrics reporting
<img width="990" alt="image" src="https://user-images.githubusercontent.com/23372859/229807728-2848da99-bdb3-4c00-8623-ea281e5ca6a6.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sumitagrawl commented on a diff in pull request #4533: HDDS-8228. Add metric for out of order/retried delete transactions
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl commented on code in PR #4533:
URL: https://github.com/apache/ozone/pull/4533#discussion_r1159205751
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java:
##########
@@ -486,6 +489,7 @@ private void logDeleteTransaction(long containerId,
}
if (delTX.getTxID() <= containerData.getDeleteTransactionId()) {
+ blockDeleteMetrics.incrFailureCount();
Review Comment:
@adoroszlai Updated...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] aryangupta1998 merged pull request #4533: HDDS-8228. Add metric for out of order/retried delete transactions
Posted by "aryangupta1998 (via GitHub)" <gi...@apache.org>.
aryangupta1998 merged PR #4533:
URL: https://github.com/apache/ozone/pull/4533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #4533: HDDS-8228. Add metric for out of order/retried delete transactions
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #4533:
URL: https://github.com/apache/ozone/pull/4533#discussion_r1158470423
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java:
##########
@@ -486,6 +489,7 @@ private void logDeleteTransaction(long containerId,
}
if (delTX.getTxID() <= containerData.getDeleteTransactionId()) {
+ blockDeleteMetrics.incrFailureCount();
Review Comment:
I guess this should increment the new metric.
```suggestion
blockDeleteMetrics.incOutOfOrderDeleteBlockTransactionCount();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org