You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2011/01/21 15:09:43 UTC

[jira] Created: (QPID-3013) ConnectionCloseTest fails on machines with increased processer counts

ConnectionCloseTest fails on machines with increased processer counts
---------------------------------------------------------------------

                 Key: QPID-3013
                 URL: https://issues.apache.org/jira/browse/QPID-3013
             Project: Qpid
          Issue Type: Test
          Components: Java Broker, Java Client
    Affects Versions: 0.8
            Reporter: Robbie Gemmell
            Assignee: Robbie Gemmell
            Priority: Minor
             Fix For: 0.9


ConnectionCloseTest fails on machines with increased processer counts. This is because it does allow for the larger number of threads that can be assigned to thread pools created in the MINA codebase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-3013) ConnectionCloseTest fails on machines with increased processor counts

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-3013:
---------------------------------

    Description: ConnectionCloseTest fails on machines with increased processor counts. This is because it does allow for the larger number of threads that can be assigned to thread pools created in the MINA codebase.  (was: ConnectionCloseTest fails on machines with increased processer counts. This is because it does allow for the larger number of threads that can be assigned to thread pools created in the MINA codebase.)
        Summary: ConnectionCloseTest fails on machines with increased processor counts  (was: ConnectionCloseTest fails on machines with increased processer counts)

> ConnectionCloseTest fails on machines with increased processor counts
> ---------------------------------------------------------------------
>
>                 Key: QPID-3013
>                 URL: https://issues.apache.org/jira/browse/QPID-3013
>             Project: Qpid
>          Issue Type: Test
>          Components: Java Broker, Java Client
>    Affects Versions: 0.8
>            Reporter: Robbie Gemmell
>            Assignee: Andrew Kennedy
>            Priority: Minor
>             Fix For: 0.9
>
>
> ConnectionCloseTest fails on machines with increased processor counts. This is because it does allow for the larger number of threads that can be assigned to thread pools created in the MINA codebase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-3013) ConnectionCloseTest fails on machines with increased processor counts

Posted by "Andrew Kennedy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985722#action_12985722 ] 

Andrew Kennedy commented on QPID-3013:
--------------------------------------

Good idea, but should move the intialConnection.close() to after counting the threads for the second time, as in the sequence below. Additionally, the delta check should be scalable with the number of CPUs - see step 5 below, although the coefficients may need fixing, as I just guessed:

1. start initial connection
2. count threads T_1
3. perform test
4. count threads T_2
5. delta = T_2 - T_1 <= (a * CPUs) + b : { a = 2, b = 4 }
6. close initial connection

> ConnectionCloseTest fails on machines with increased processor counts
> ---------------------------------------------------------------------
>
>                 Key: QPID-3013
>                 URL: https://issues.apache.org/jira/browse/QPID-3013
>             Project: Qpid
>          Issue Type: Test
>          Components: Java Broker, Java Client
>    Affects Versions: 0.8
>            Reporter: Robbie Gemmell
>            Assignee: Andrew Kennedy
>            Priority: Minor
>             Fix For: 0.9
>
>
> ConnectionCloseTest fails on machines with increased processor counts. This is because it does allow for the larger number of threads that can be assigned to thread pools created in the MINA codebase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Assigned: (QPID-3013) ConnectionCloseTest fails on machines with increased processer counts

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell reassigned QPID-3013:
------------------------------------

    Assignee: Andrew Kennedy  (was: Robbie Gemmell)

Andrew can you review please? Thanks 

> ConnectionCloseTest fails on machines with increased processer counts
> ---------------------------------------------------------------------
>
>                 Key: QPID-3013
>                 URL: https://issues.apache.org/jira/browse/QPID-3013
>             Project: Qpid
>          Issue Type: Test
>          Components: Java Broker, Java Client
>    Affects Versions: 0.8
>            Reporter: Robbie Gemmell
>            Assignee: Andrew Kennedy
>            Priority: Minor
>             Fix For: 0.9
>
>
> ConnectionCloseTest fails on machines with increased processer counts. This is because it does allow for the larger number of threads that can be assigned to thread pools created in the MINA codebase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-3013) ConnectionCloseTest fails on machines with increased processer counts

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-3013:
---------------------------------

    Status: Ready To Review  (was: In Progress)

> ConnectionCloseTest fails on machines with increased processer counts
> ---------------------------------------------------------------------
>
>                 Key: QPID-3013
>                 URL: https://issues.apache.org/jira/browse/QPID-3013
>             Project: Qpid
>          Issue Type: Test
>          Components: Java Broker, Java Client
>    Affects Versions: 0.8
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>            Priority: Minor
>             Fix For: 0.9
>
>
> ConnectionCloseTest fails on machines with increased processer counts. This is because it does allow for the larger number of threads that can be assigned to thread pools created in the MINA codebase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-3013) ConnectionCloseTest fails on machines with increased processor counts

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987528#action_12987528 ] 

Robbie Gemmell commented on QPID-3013:
--------------------------------------

Removed the initial connection, moving its closure showed that only the encessary threads in the pools were started and so it wasnt having the desired effect of taing the pool size out of the equation afterall.

Added a processor count based variable delta instead.

> ConnectionCloseTest fails on machines with increased processor counts
> ---------------------------------------------------------------------
>
>                 Key: QPID-3013
>                 URL: https://issues.apache.org/jira/browse/QPID-3013
>             Project: Qpid
>          Issue Type: Test
>          Components: Java Broker, Java Client
>    Affects Versions: 0.8
>            Reporter: Robbie Gemmell
>            Assignee: Andrew Kennedy
>            Priority: Minor
>             Fix For: 0.9
>
>
> ConnectionCloseTest fails on machines with increased processor counts. This is because it does allow for the larger number of threads that can be assigned to thread pools created in the MINA codebase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Resolved: (QPID-3013) ConnectionCloseTest fails on machines with increased processor counts

Posted by "Andrew Kennedy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy resolved QPID-3013.
----------------------------------

    Resolution: Fixed

Works, but we need to verify this behaviour on a machine where N_processors is large, say 128 or 256?

> ConnectionCloseTest fails on machines with increased processor counts
> ---------------------------------------------------------------------
>
>                 Key: QPID-3013
>                 URL: https://issues.apache.org/jira/browse/QPID-3013
>             Project: Qpid
>          Issue Type: Test
>          Components: Java Broker, Java Client
>    Affects Versions: 0.8
>            Reporter: Robbie Gemmell
>            Assignee: Andrew Kennedy
>            Priority: Minor
>             Fix For: 0.9
>
>
> ConnectionCloseTest fails on machines with increased processor counts. This is because it does allow for the larger number of threads that can be assigned to thread pools created in the MINA codebase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org