You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/03/30 06:45:44 UTC
[GitHub] [pulsar-adapters] dlg99 opened a new pull request #9: build pulsar-adaptors with pulsar-2.8-snapshot
dlg99 opened a new pull request #9:
URL: https://github.com/apache/pulsar-adapters/pull/9
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #5
### Motivation
Tried building pulsar-adaptors locally with 2.8.0-SNAPSHOT.
Build failed.
Tried building with pulsar 2.7.1 release
Build fails.
Last pulsar-adaptors released with 2.6.x.
Some tests won't compile even with 2.7.1 release.
### Modifications
Made it build with locally built pulsar 2.8.0-SNAPSHOT (build as `mvn clean install -DskipTests`)
Updated pom files to include dependencies that project needed, same versions as pulsar IIRC.
Fixed tests that failed after all that (due to changes in pulsar).
One test needs fix in the pulsar, PR tbd, change is
```
diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
index 4a3091bbad4..fd1d5a092df 100644
--- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
+++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
@@ -24,6 +24,7 @@ import java.time.Clock;
import java.util.Set;
import lombok.AllArgsConstructor;
import lombok.Data;
+import lombok.EqualsAndHashCode;
import lombok.NoArgsConstructor;
import org.apache.pulsar.client.api.Authentication;
import org.apache.pulsar.client.api.ProxyProtocol;
@@ -46,9 +47,11 @@ public class ClientConfigurationData implements Serializable, Cloneable {
private String serviceUrl;
@JsonIgnore
+ @EqualsAndHashCode.Exclude
private transient ServiceUrlProvider serviceUrlProvider;
@JsonIgnore
+ @EqualsAndHashCode.Exclude
private Authentication authentication;
private String authPluginClassName;
@@ -102,6 +105,7 @@ public class ClientConfigurationData implements Serializable, Cloneable {
private boolean enableTransaction = false;
@JsonIgnore
+ @EqualsAndHashCode.Exclude
private Clock clock = Clock.systemDefaultZone();
public Authentication getAuthentication() {
```
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as *(please describe tests)*.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (probably, should match pulsar's)
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-adapters] dlg99 commented on pull request #9: build pulsar-adaptors with pulsar-2.8-snapshot
Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #9:
URL: https://github.com/apache/pulsar-adapters/pull/9#issuecomment-810571280
@eolivelli I am detaching project.version from pulsar.version and project.groupId from pulsar's groupId because:
- eventually we'll have to release pulsar-adapters and pulsar independently. i.e. pulsar-adapters need a minor release to patch some issues, do we wait for pulsar's minor release if it is not ready yet?
- it makes sense to move to dependency on the pulsar's release. It will speed up build (no need to rebuild pulsar) and will create stable snapshot of the dependencies to build with.
I'll clean up commented out stuff after I hear some more feedback. Part of it is just me running out of time and energy to deal with checkstyle an other stuff that didn't work atm; we'll need to return to this eventually, but not in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-adapters] eolivelli commented on pull request #9: build pulsar-adaptors with pulsar-2.8-snapshot
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9:
URL: https://github.com/apache/pulsar-adapters/pull/9#issuecomment-815897940
@rdhabalia @merlimat can you help merging this patch ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-adapters] eolivelli commented on pull request #9: build pulsar-adaptors with pulsar-2.8-snapshot
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9:
URL: https://github.com/apache/pulsar-adapters/pull/9#issuecomment-815947164
@sijie
> @eolivelli Can you request @codelipenghui for reviews for future PRs?
got it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-adapters] eolivelli commented on a change in pull request #9: build pulsar-adaptors with pulsar-2.8-snapshot
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #9:
URL: https://github.com/apache/pulsar-adapters/pull/9#discussion_r603836052
##########
File path: examples/flink/pom.xml
##########
@@ -36,7 +37,7 @@
</properties>
<dependencies>
- <dependency>
+ <!--dependency>
Review comment:
can we remove commented code ?
##########
File path: pulsar-client-kafka-compat/pulsar-client-kafka-tests/pom.xml
##########
@@ -44,32 +44,32 @@
</dependency>
<dependency>
- <groupId>${project.groupId}</groupId>
+ <groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-broker</artifactId>
- <version>${project.version}</version>
+ <version>${pulsar.version}</version>
Review comment:
why this is not project.version ?
##########
File path: pulsar-client-kafka-compat/pulsar-client-kafka-tests/pom.xml
##########
@@ -44,32 +44,32 @@
</dependency>
<dependency>
- <groupId>${project.groupId}</groupId>
Review comment:
why this is not project.groupId ?
##########
File path: pulsar-flink/pom.xml
##########
@@ -139,13 +197,13 @@
<goal>schema</goal>
</goals>
<configuration>
- <testSourceDirectory>${project.basedir}/src/test/resources/avro</testSourceDirectory>
- <testOutputDirectory>${project.basedir}/src/test/java/</testOutputDirectory>
+ <testSourceDirectory>${project.basedir}/src/test/resources/avro/</testSourceDirectory>
</configuration>
</execution>
</executions>
</plugin>
- <plugin>
+
+ <!-- plugin>
Review comment:
please remove commented code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-adapters] eolivelli merged pull request #9: build pulsar-adaptors with pulsar-2.8-snapshot
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #9:
URL: https://github.com/apache/pulsar-adapters/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-adapters] sijie commented on pull request #9: build pulsar-adaptors with pulsar-2.8-snapshot
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9:
URL: https://github.com/apache/pulsar-adapters/pull/9#issuecomment-815944608
@codelipenghui Can you review it?
@eolivelli Can you request @codelipenghui for reviews for future PRs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-adapters] sijie commented on pull request #9: build pulsar-adaptors with pulsar-2.8-snapshot
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9:
URL: https://github.com/apache/pulsar-adapters/pull/9#issuecomment-815948548
@eolivelli it would be good to make sure another review like from @codelipenghui before merging this, because I have already tagged him.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-adapters] dlg99 commented on pull request #9: build pulsar-adaptors with pulsar-2.8-snapshot
Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #9:
URL: https://github.com/apache/pulsar-adapters/pull/9#issuecomment-810473114
https://github.com/apache/pulsar/pull/10091 for pulsar-side fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-adapters] eolivelli commented on pull request #9: build pulsar-adaptors with pulsar-2.8-snapshot
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9:
URL: https://github.com/apache/pulsar-adapters/pull/9#issuecomment-811657599
@merlimat @sijie can we commit this patch and unblock the repository?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-adapters] eolivelli commented on pull request #9: build pulsar-adaptors with pulsar-2.8-snapshot
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9:
URL: https://github.com/apache/pulsar-adapters/pull/9#issuecomment-815966514
@sijie sorry.
I thought that that your comment was for the next time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org