You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2014/10/29 14:21:11 UTC
Review Request 27326: [FALCON-844] List instances tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27326/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-844
https://issues.apache.org/jira/browse/FALCON-844
Repository: falcon-git
Description
-------
Testing of api/instance/list API
Diffs
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 2f588ef
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/InstancesResult.java 45ca85e
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 73cf8c8
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 3a63e7c
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27326/diff/
Testing
-------
Tested locally, except 2 tests which fail on old cluster because of https://issues.apache.org/jira/browse/FALCON-840 and currently can't be tested on new one.
Expecting them to pass on new build because https://issues.apache.org/jira/browse/FALCON-840 was resolved.
Thanks,
Paul Isaychuk
Re: Review Request 27326: [FALCON-844] List instances tests
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27326/#review58979
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/InstancesResult.java
<https://reviews.apache.org/r/27326/#comment100232>
reordered due to check of orderBy status param
- Paul Isaychuk
On Oct. 29, 2014, 1:21 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27326/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 1:21 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-844
> https://issues.apache.org/jira/browse/FALCON-844
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Testing of api/instance/list API
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 2f588ef
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/InstancesResult.java 45ca85e
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 73cf8c8
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 3a63e7c
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27326/diff/
>
>
> Testing
> -------
>
> Tested locally, except 2 tests which fail on old cluster because of https://issues.apache.org/jira/browse/FALCON-840 and currently can't be tested on new one.
> Expecting them to pass on new build because https://issues.apache.org/jira/browse/FALCON-840 was resolved.
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 27326: [FALCON-844] List instances tests
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27326/#review59189
-----------------------------------------------------------
Ship it!
Ship It!
- Ruslan Ostafiychuk
On Oct. 29, 2014, 3:36 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27326/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 3:36 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-844
> https://issues.apache.org/jira/browse/FALCON-844
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Testing of api/instance/list API
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 2f588ef
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java 024a652
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 3a63e7c
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27326/diff/
>
>
> Testing
> -------
>
> Tested locally, except 2 tests which fail on old cluster because of https://issues.apache.org/jira/browse/FALCON-840 and currently can't be tested on new one.
> Expecting them to pass on new build because https://issues.apache.org/jira/browse/FALCON-840 was resolved.
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 27326: [FALCON-844] List instances tests
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27326/
-----------------------------------------------------------
(Updated Oct. 29, 2014, 3:36 p.m.)
Review request for Falcon.
Changes
-------
Comments addressed. Totally 4 tests fail now. 2 because of mentioned https://issues.apache.org/jira/browse/FALCON-840 (on my old cluster) but they are expected to pass on new build.
And other 2 fail because api returns instances which are incorrectly ordered by their status.
Bugs: FALCON-844
https://issues.apache.org/jira/browse/FALCON-844
Repository: falcon-git
Description
-------
Testing of api/instance/list API
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 2f588ef
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java 024a652
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 3a63e7c
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27326/diff/
Testing
-------
Tested locally, except 2 tests which fail on old cluster because of https://issues.apache.org/jira/browse/FALCON-840 and currently can't be tested on new one.
Expecting them to pass on new build because https://issues.apache.org/jira/browse/FALCON-840 was resolved.
Thanks,
Paul Isaychuk
Re: Review Request 27326: [FALCON-844] List instances tests
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27326/#review58981
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/InstancesResult.java
<https://reviews.apache.org/r/27326/#comment100236>
Should not be changed
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java
<https://reviews.apache.org/r/27326/#comment100235>
HadoopUtil.createFolders() can be used
- Ruslan Ostafiychuk
On Oct. 29, 2014, 1:21 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27326/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 1:21 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-844
> https://issues.apache.org/jira/browse/FALCON-844
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Testing of api/instance/list API
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 2f588ef
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/InstancesResult.java 45ca85e
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 73cf8c8
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 3a63e7c
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27326/diff/
>
>
> Testing
> -------
>
> Tested locally, except 2 tests which fail on old cluster because of https://issues.apache.org/jira/browse/FALCON-840 and currently can't be tested on new one.
> Expecting them to pass on new build because https://issues.apache.org/jira/browse/FALCON-840 was resolved.
>
>
> Thanks,
>
> Paul Isaychuk
>
>