[GitHub] [pulsar] kimcs commented on a change in pull request #4445: Include pulsar-client-api in shaded client artifacts

[GitBox <gi...@apache.org>]

kimcs commented on a change in pull request #4445: Include pulsar-client-api in shaded client artifacts
URL: https://github.com/apache/pulsar/pull/4445#discussion_r290287011
 
 

 ##########
 File path: pulsar-client-shaded/pom.xml
 ##########
 @@ -91,6 +91,7 @@
 
               <artifactSet>
                 <includes>
+                  <include>org.apache.pulsar:pulsar-client-api</include>
 
 Review comment:
   @merlimat
   
   I would think that being able to use pulsar client with a recent version of java that has the module system enabled is important. There are ways to get around this though. Here are some alternatives:
   
   1. Accept this PR and a poorer IDE experience. Users can still use the non-shaded original artifacts. Maybe also make a source jar for the shaded jar for the pulsar parts of the code.
   
   2. Fix the split package issue once and for all by moving the classes in the packages that are affected by split-package problem in the pulsar-client-api (or pulsar-common) module to another package. This would be the long-term preferred solution, and the only reason for not doing this would be to maintain backwards-compatibility for external clients.
   
   3. Duplicate the pulsar-client-shaded and pulsar-client-admin-shaded modules and rename the duplicates with a suffix calling them for example pulsar-client-jpms and pulsar-client-admin-jpms or something else, and then publish these on maven central. This is very similar to what is done with the existing pulsar-client-all module which has not been published to maven central so far, and that brings me to the next alternative.
   
   4. Publish pulsar-client-all on maven central along with all the other pulsar client modules. This provides at least one shaded module that can be used properly with recent java clients with jpms enabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services