You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2023/01/03 16:01:09 UTC

[GitHub] [daffodil] tuxji commented on a diff in pull request #897: Update release-candidate to install VS Code Extension docs.

tuxji commented on code in PR #897:
URL: https://github.com/apache/daffodil/pull/897#discussion_r1060724876


##########
containers/release-candidate/Dockerfile:
##########
@@ -42,6 +43,10 @@ RUN \
     winetricks && \
   dnf clean all
 
+# Install node dependencies:
+#   github-wikito-converter - creates html doc from github wiki repo
+RUN npm install -g github-wikito-converter

Review Comment:
   Reviewing again as you requested. I don't know how much data npm install downloads under the covers, but if we go to the trouble of calling dnf clean all to clear everything that was downloaded and cached by dnf install, is there any equivalent command we want to append to this line to clear any npm cache?  Other than that, I believe you're good to squash and merge.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org