[GitHub] [cassandra] dcapwell commented on pull request #2310: CASSANDRA-18504: Added support for type VECTOR

["dcapwell (via GitHub)" <gi...@apache.org>]

dcapwell commented on PR #2310:
URL: https://github.com/apache/cassandra/pull/2310#issuecomment-1572551075

   > @dcapwell We having been playing with this code on our vector graph implementation and have just found that any saved SSTables with `VectorType` in them fail to load at startup because `VectorType` is missing a `public static <T> VectorType<T> getInstance(TypeParser parser)` implementation. Adding this requires support adding to `TypeParser` to pull the abstract type and dimensions from the string representation of the type.
   
   Ah great reply, I'll try to figure out why the tests do not detect this (is this due to them being Memtable only?); will also add such a check to the type test so we detect this for all types!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org