You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2025/11/24 13:32:21 UTC
[PR] [fix](inverted index) fix wrong fs move in index_file_reader [doris]
airborne12 opened a new pull request, #58317:
URL: https://github.com/apache/doris/pull/58317
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix fs set when meet segment corruption [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3575924336
<details>
<summary>ClickBench: <b>Total hot run time: 27.35 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 347efbc9bbc7cc99fb29dbd1239445e4b6c275c6, data reload: false
query1 0.06 0.04 0.04
query2 0.09 0.05 0.05
query3 0.25 0.08 0.08
query4 1.63 0.11 0.11
query5 0.26 0.26 0.26
query6 1.18 0.65 0.65
query7 0.03 0.03 0.02
query8 0.06 0.04 0.05
query9 0.58 0.51 0.52
query10 0.58 0.58 0.58
query11 0.16 0.12 0.11
query12 0.15 0.12 0.12
query13 0.61 0.60 0.60
query14 1.01 1.01 0.99
query15 0.84 0.83 0.84
query16 0.39 0.38 0.39
query17 1.01 1.03 1.03
query18 0.22 0.19 0.19
query19 1.90 1.84 1.80
query20 0.02 0.01 0.00
query21 15.44 0.18 0.13
query22 5.16 0.07 0.05
query23 15.66 0.27 0.11
query24 3.00 0.85 0.32
query25 0.08 0.06 0.06
query26 0.14 0.14 0.12
query27 0.07 0.05 0.05
query28 3.30 1.14 0.93
query29 12.63 3.92 3.22
query30 0.28 0.14 0.11
query31 2.82 0.58 0.38
query32 3.25 0.54 0.46
query33 3.01 3.12 3.02
query34 15.88 5.17 4.57
query35 4.57 4.60 4.60
query36 0.67 0.51 0.49
query37 0.10 0.06 0.06
query38 0.07 0.04 0.03
query39 0.03 0.02 0.03
query40 0.17 0.15 0.14
query41 0.09 0.03 0.03
query42 0.04 0.03 0.03
query43 0.05 0.03 0.04
Total cold run time: 97.54 s
Total hot run time: 27.35 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix fs set when meet segment corruption [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3575760566
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix fs set when meet segment corruption [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3578285961
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix wrong fs move in index_file_reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3571555939
# BE Regression && UT Coverage Report
Increment line coverage `80.00% (4/5)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58317_a0f7d552981d2ecea5d5f5c5ec200b776f482053_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58317_a0f7d552981d2ecea5d5f5c5ec200b776f482053_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.56% (24405/34104) |
| Line Coverage | 58.04% (253742/437174) |
| Region Coverage | 53.35% (211804/396995) |
| Branch Coverage | 54.67% (90284/165135) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix fs set when meet segment corruption [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3578504155
<details>
<summary>TPC-DS: <b>Total hot run time: 184396 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 81c4eb2331b7fdfec679766214b6b6ec8fd8a151, data reload: false
query1 1114 422 412 412
query2 6631 1595 1571 1571
query3 6836 234 220 220
query4 26008 22898 22883 22883
query5 4433 660 472 472
query6 345 250 228 228
query7 4671 497 315 315
query8 307 262 252 252
query9 8718 2582 2593 2582
query10 547 354 311 311
query11 15397 14840 14623 14623
query12 248 120 116 116
query13 1694 579 469 469
query14 11158 8970 8925 8925
query15 220 205 189 189
query16 7705 691 546 546
query17 1263 775 659 659
query18 2064 439 339 339
query19 227 210 191 191
query20 127 125 128 125
query21 471 137 115 115
query22 3942 4028 3880 3880
query23 33020 32050 31975 31975
query24 8426 2434 2456 2434
query25 699 550 485 485
query26 1293 318 156 156
query27 2660 506 357 357
query28 4366 2126 2113 2113
query29 793 596 485 485
query30 342 242 210 210
query31 860 702 616 616
query32 83 73 85 73
query33 583 377 333 333
query34 789 854 530 530
query35 807 826 754 754
query36 912 936 830 830
query37 116 106 87 87
query38 3298 3297 3269 3269
query39 1482 1407 1401 1401
query40 225 126 121 121
query41 65 60 60 60
query42 125 111 109 109
query43 464 464 436 436
query44 1240 758 767 758
query45 195 185 182 182
query46 881 982 646 646
query47 1707 1742 1641 1641
query48 399 427 318 318
query49 785 491 402 402
query50 635 673 412 412
query51 3964 4006 3867 3867
query52 114 111 105 105
query53 287 270 202 202
query54 314 294 279 279
query55 92 88 91 88
query56 330 316 310 310
query57 1136 1179 1093 1093
query58 280 266 271 266
query59 2310 2475 2330 2330
query60 344 351 350 350
query61 160 154 152 152
query62 790 717 645 645
query63 219 194 194 194
query64 4491 1191 875 875
query65 4034 4002 3992 3992
query66 1090 452 337 337
query67 15074 15249 14714 14714
query68 8467 940 624 624
query69 502 346 302 302
query70 1302 1305 1188 1188
query71 498 332 323 323
query72 5674 4934 4820 4820
query73 735 595 376 376
query74 8855 8771 8604 8604
query75 4060 3315 2778 2778
query76 3816 1115 741 741
query77 830 392 316 316
query78 9476 9904 8898 8898
query79 1954 796 605 605
query80 654 588 504 504
query81 490 271 238 238
query82 424 165 130 130
query83 271 273 253 253
query84 254 117 98 98
query85 905 468 433 433
query86 341 298 288 288
query87 3540 3489 3468 3468
query88 3250 2256 2263 2256
query89 390 331 290 290
query90 1974 224 225 224
query91 182 166 138 138
query92 81 68 59 59
query93 1216 985 651 651
query94 760 462 372 372
query95 531 414 386 386
query96 497 563 279 279
query97 2917 2949 2857 2857
query98 238 218 215 215
query99 1403 1430 1267 1267
Total cold run time: 272892 ms
Total hot run time: 184396 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix wrong fs move in index_file_reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3571020176
<details>
<summary>TPC-DS: <b>Total hot run time: 183794 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a0f7d552981d2ecea5d5f5c5ec200b776f482053, data reload: false
query1 1050 398 422 398
query2 6562 1627 1575 1575
query3 6776 228 220 220
query4 26010 22968 22632 22632
query5 4418 633 458 458
query6 328 237 224 224
query7 4648 500 294 294
query8 302 247 246 246
query9 8704 2585 2536 2536
query10 520 364 320 320
query11 15294 14887 14576 14576
query12 177 118 112 112
query13 1692 583 456 456
query14 10811 8882 8917 8882
query15 206 197 185 185
query16 7281 673 472 472
query17 1261 789 641 641
query18 2001 436 347 347
query19 217 206 182 182
query20 140 133 124 124
query21 219 136 123 123
query22 3887 4100 3823 3823
query23 32927 32318 31932 31932
query24 8460 2399 2394 2394
query25 608 547 476 476
query26 740 283 171 171
query27 2668 505 360 360
query28 4336 2173 2164 2164
query29 778 649 525 525
query30 320 241 210 210
query31 828 693 623 623
query32 87 75 73 73
query33 621 387 347 347
query34 793 875 513 513
query35 810 857 790 790
query36 921 968 866 866
query37 125 111 90 90
query38 3297 3264 3224 3224
query39 1456 1400 1417 1400
query40 216 129 118 118
query41 66 61 60 60
query42 123 109 119 109
query43 466 455 433 433
query44 1233 760 761 760
query45 196 189 184 184
query46 885 993 643 643
query47 1699 1700 1675 1675
query48 399 419 334 334
query49 729 502 407 407
query50 648 687 413 413
query51 3869 3889 3911 3889
query52 109 113 103 103
query53 236 260 187 187
query54 312 290 282 282
query55 89 82 90 82
query56 330 315 304 304
query57 1160 1185 1084 1084
query58 282 279 266 266
query59 2369 2492 2323 2323
query60 346 339 328 328
query61 161 160 159 159
query62 795 716 660 660
query63 225 189 189 189
query64 3293 1197 879 879
query65 4109 3945 3922 3922
query66 1033 423 322 322
query67 15275 14868 14774 14774
query68 8283 917 652 652
query69 520 344 298 298
query70 1277 1190 1194 1190
query71 473 327 288 288
query72 5639 4844 4870 4844
query73 688 578 364 364
query74 8593 8755 8595 8595
query75 4000 3291 2890 2890
query76 3716 1130 701 701
query77 819 393 309 309
query78 9457 9639 8942 8942
query79 2022 813 588 588
query80 625 579 486 486
query81 491 272 230 230
query82 425 165 136 136
query83 272 266 253 253
query84 252 111 100 100
query85 918 476 430 430
query86 345 286 282 282
query87 3445 3451 3359 3359
query88 3541 2243 2235 2235
query89 388 326 282 282
query90 1940 223 219 219
query91 178 169 140 140
query92 81 66 62 62
query93 1271 995 670 670
query94 715 453 318 318
query95 497 407 401 401
query96 499 564 276 276
query97 2914 2966 2869 2869
query98 237 205 212 205
query99 1427 1373 1307 1307
Total cold run time: 268880 ms
Total hot run time: 183794 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix wrong fs move in index_file_reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3571047790
<details>
<summary>ClickBench: <b>Total hot run time: 27.48 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a0f7d552981d2ecea5d5f5c5ec200b776f482053, data reload: false
query1 0.06 0.04 0.05
query2 0.09 0.06 0.05
query3 0.25 0.08 0.08
query4 1.60 0.11 0.12
query5 0.26 0.26 0.25
query6 1.18 0.65 0.64
query7 0.04 0.03 0.02
query8 0.05 0.04 0.04
query9 0.58 0.52 0.52
query10 0.58 0.57 0.57
query11 0.16 0.11 0.11
query12 0.15 0.12 0.12
query13 0.62 0.60 0.61
query14 1.02 1.01 0.99
query15 0.86 0.82 0.84
query16 0.40 0.39 0.39
query17 1.01 1.02 1.01
query18 0.21 0.19 0.20
query19 1.85 1.82 1.78
query20 0.04 0.01 0.01
query21 15.45 0.20 0.13
query22 4.97 0.06 0.05
query23 15.68 0.26 0.10
query24 2.51 0.50 0.81
query25 0.08 0.07 0.06
query26 0.14 0.15 0.14
query27 0.06 0.06 0.05
query28 4.88 1.14 0.94
query29 12.56 3.91 3.23
query30 0.28 0.15 0.11
query31 2.82 0.58 0.39
query32 3.23 0.54 0.48
query33 3.11 3.18 3.04
query34 15.86 5.12 4.55
query35 4.58 4.62 4.51
query36 0.68 0.49 0.48
query37 0.10 0.07 0.07
query38 0.07 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.14 0.14
query41 0.08 0.04 0.03
query42 0.03 0.03 0.03
query43 0.04 0.04 0.04
Total cold run time: 98.43 s
Total hot run time: 27.48 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix wrong fs move in index_file_reader [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3571123227
# BE UT Coverage Report
Increment line coverage `60.00% (3/5)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/a0f7d552981d2ecea5d5f5c5ec200b776f482053_a0f7d552981d2ecea5d5f5c5ec200b776f482053/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/a0f7d552981d2ecea5d5f5c5ec200b776f482053_a0f7d552981d2ecea5d5f5c5ec200b776f482053/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.64% (18290/34746) |
| Line Coverage | 38.06% (166352/437033) |
| Region Coverage | 33.02% (129318/391694) |
| Branch Coverage | 33.81% (55499/164138) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix fs set when meet segment corruption [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3578579515
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix fs set when meet segment corruption [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3578455829
<details>
<summary>TPC-H: <b>Total hot run time: 34139 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 81c4eb2331b7fdfec679766214b6b6ec8fd8a151, data reload: false
------ Round 1 ----------------------------------
q1 17740 5093 4917 4917
q2 2304 309 202 202
q3 10190 1252 702 702
q4 10391 877 384 384
q5 7524 2405 2354 2354
q6 180 168 142 142
q7 985 771 658 658
q8 9341 1240 1034 1034
q9 7068 5287 5272 5272
q10 7292 2233 1816 1816
q11 515 303 281 281
q12 348 361 226 226
q13 17830 3603 2979 2979
q14 223 242 233 233
q15 603 513 502 502
q16 1032 1024 973 973
q17 679 867 352 352
q18 7449 7036 7023 7023
q19 1266 948 563 563
q20 369 345 231 231
q21 3931 3173 2343 2343
q22 1003 1006 952 952
Total cold run time: 108263 ms
Total hot run time: 34139 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5034 4970 4948 4948
q2 325 401 322 322
q3 2185 2679 2327 2327
q4 1364 1760 1345 1345
q5 4321 4534 4514 4514
q6 206 171 132 132
q7 2026 2000 1825 1825
q8 2627 2578 2517 2517
q9 7522 7494 7499 7494
q10 3044 3226 2830 2830
q11 580 508 504 504
q12 645 726 611 611
q13 3586 3905 3283 3283
q14 282 306 298 298
q15 556 512 506 506
q16 1086 1127 1055 1055
q17 1199 1618 1384 1384
q18 7857 7642 7517 7517
q19 790 759 865 759
q20 1905 1980 1821 1821
q21 4693 4305 4240 4240
q22 1079 1030 1002 1002
Total cold run time: 52912 ms
Total hot run time: 51234 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix wrong fs move in index_file_reader [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3570814539
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix wrong fs move in index_file_reader [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3570962185
<details>
<summary>TPC-H: <b>Total hot run time: 34198 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a0f7d552981d2ecea5d5f5c5ec200b776f482053, data reload: false
------ Round 1 ----------------------------------
q1 17620 5017 4890 4890
q2 2041 311 199 199
q3 10271 1282 723 723
q4 10225 934 371 371
q5 7544 2406 2332 2332
q6 181 165 134 134
q7 931 762 619 619
q8 9337 1328 1087 1087
q9 7115 5307 5299 5299
q10 6891 2247 1804 1804
q11 487 302 281 281
q12 351 361 212 212
q13 17774 3621 3023 3023
q14 223 229 210 210
q15 610 510 511 510
q16 1038 1013 956 956
q17 583 874 405 405
q18 7383 7125 7125 7125
q19 1289 937 543 543
q20 347 334 227 227
q21 3710 3181 2277 2277
q22 1013 992 971 971
Total cold run time: 106964 ms
Total hot run time: 34198 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4959 4925 4892 4892
q2 325 401 316 316
q3 2162 2650 2270 2270
q4 1337 1734 1317 1317
q5 4238 4368 4513 4368
q6 215 176 132 132
q7 2122 1956 1809 1809
q8 2710 2714 2560 2560
q9 7574 7495 7552 7495
q10 3054 3210 2793 2793
q11 579 529 502 502
q12 716 761 645 645
q13 3450 3892 3405 3405
q14 282 303 293 293
q15 543 499 508 499
q16 1113 1124 1081 1081
q17 1175 1531 1382 1382
q18 7944 7662 7459 7459
q19 767 793 851 793
q20 1948 1968 1804 1804
q21 4677 4264 4259 4259
q22 1116 1053 1021 1021
Total cold run time: 53006 ms
Total hot run time: 51095 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix fs set when meet segment corruption [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3575690076
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix fs set when meet segment corruption [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3575902770
<details>
<summary>TPC-DS: <b>Total hot run time: 182349 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 347efbc9bbc7cc99fb29dbd1239445e4b6c275c6, data reload: false
query1 1068 407 392 392
query2 6560 1612 1597 1597
query3 6754 235 221 221
query4 25359 22562 22625 22562
query5 4459 640 465 465
query6 327 230 216 216
query7 4643 489 298 298
query8 299 270 258 258
query9 8700 2576 2549 2549
query10 541 365 304 304
query11 15043 14880 14611 14611
query12 186 117 107 107
query13 1694 587 457 457
query14 10127 8846 8915 8846
query15 222 202 193 193
query16 7574 722 548 548
query17 1267 799 627 627
query18 2017 430 329 329
query19 207 200 181 181
query20 129 121 117 117
query21 226 133 109 109
query22 3880 4120 3881 3881
query23 32779 32292 32153 32153
query24 8452 2426 2406 2406
query25 598 510 448 448
query26 1236 270 158 158
query27 2751 499 356 356
query28 4363 2145 2126 2126
query29 822 651 492 492
query30 308 241 208 208
query31 812 719 636 636
query32 80 76 72 72
query33 590 366 322 322
query34 763 866 525 525
query35 816 850 745 745
query36 930 951 881 881
query37 112 103 86 86
query38 3298 3313 3318 3313
query39 1495 1416 1432 1416
query40 225 131 119 119
query41 66 75 63 63
query42 124 111 112 111
query43 473 477 439 439
query44 1227 774 768 768
query45 195 188 195 188
query46 886 1009 640 640
query47 1722 1732 1654 1654
query48 408 430 323 323
query49 776 501 394 394
query50 644 674 411 411
query51 3820 4052 3842 3842
query52 122 118 114 114
query53 252 268 194 194
query54 313 291 273 273
query55 87 86 83 83
query56 342 330 320 320
query57 1178 1186 1093 1093
query58 282 276 264 264
query59 2346 2570 2459 2459
query60 345 354 326 326
query61 161 165 162 162
query62 793 712 674 674
query63 230 199 194 194
query64 4598 1269 878 878
query65 4088 3971 3995 3971
query66 1155 433 320 320
query67 15396 15067 14969 14969
query68 6777 899 620 620
query69 521 330 314 314
query70 1252 1327 1158 1158
query71 429 362 306 306
query72 5868 2625 5397 2625
query73 778 759 381 381
query74 8618 8803 8550 8550
query75 3313 3326 2809 2809
query76 3253 1120 727 727
query77 512 402 316 316
query78 9430 9715 8917 8917
query79 1420 856 606 606
query80 680 598 492 492
query81 519 271 244 244
query82 205 165 135 135
query83 262 261 243 243
query84 252 114 102 102
query85 951 610 534 534
query86 379 294 282 282
query87 3479 3505 3421 3421
query88 2839 2267 2293 2267
query89 382 326 299 299
query90 1982 216 217 216
query91 191 186 159 159
query92 81 69 67 67
query93 1263 988 654 654
query94 752 457 344 344
query95 503 412 419 412
query96 492 573 277 277
query97 2851 2951 2883 2883
query98 230 218 218 218
query99 1328 1413 1314 1314
Total cold run time: 265533 ms
Total hot run time: 182349 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix fs set when meet segment corruption [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3575853420
<details>
<summary>TPC-H: <b>Total hot run time: 34406 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 347efbc9bbc7cc99fb29dbd1239445e4b6c275c6, data reload: false
------ Round 1 ----------------------------------
q1 17697 5065 4940 4940
q2 2017 310 208 208
q3 10271 1292 708 708
q4 10237 945 365 365
q5 7514 2338 2389 2338
q6 190 167 137 137
q7 937 792 627 627
q8 9372 1392 1180 1180
q9 7292 5452 5406 5406
q10 6965 2257 1818 1818
q11 505 304 283 283
q12 363 367 218 218
q13 17832 3634 3006 3006
q14 224 236 215 215
q15 586 518 508 508
q16 1036 1034 980 980
q17 583 859 362 362
q18 7694 7210 7056 7056
q19 1392 968 537 537
q20 353 328 230 230
q21 3730 3137 2313 2313
q22 1049 1023 971 971
Total cold run time: 107839 ms
Total hot run time: 34406 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5033 4954 4957 4954
q2 334 401 314 314
q3 2121 2733 2288 2288
q4 1356 1737 1307 1307
q5 4240 4556 4554 4554
q6 221 170 129 129
q7 2062 1966 1817 1817
q8 2678 2631 2586 2586
q9 7495 7553 7504 7504
q10 3143 3220 2816 2816
q11 601 529 493 493
q12 708 802 609 609
q13 3530 3937 3415 3415
q14 286 457 315 315
q15 571 505 508 505
q16 1068 1105 1091 1091
q17 1152 1466 1401 1401
q18 7982 7699 7567 7567
q19 805 795 896 795
q20 2061 1972 1820 1820
q21 4641 4276 4297 4276
q22 1092 1033 1006 1006
Total cold run time: 53180 ms
Total hot run time: 51562 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix wrong fs move in index_file_reader [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3570814210
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix fs set when meet segment corruption [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 merged PR #58317:
URL: https://github.com/apache/doris/pull/58317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix fs set when meet segment corruption [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3578931950
# BE Regression && UT Coverage Report
Increment line coverage `71.43% (5/7)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58317_81c4eb2331b7fdfec679766214b6b6ec8fd8a151_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58317_81c4eb2331b7fdfec679766214b6b6ec8fd8a151_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.57% (24460/34177) |
| Line Coverage | 58.05% (254663/438717) |
| Region Coverage | 53.05% (211789/399211) |
| Branch Coverage | 54.61% (90572/165844) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix fs set when meet segment corruption [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3578521990
<details>
<summary>ClickBench: <b>Total hot run time: 27.7 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 81c4eb2331b7fdfec679766214b6b6ec8fd8a151, data reload: false
query1 0.05 0.05 0.05
query2 0.13 0.05 0.05
query3 0.29 0.08 0.08
query4 1.62 0.11 0.11
query5 0.26 0.25 0.25
query6 1.17 0.64 0.65
query7 0.03 0.03 0.03
query8 0.05 0.05 0.04
query9 0.60 0.52 0.53
query10 0.58 0.58 0.58
query11 0.16 0.11 0.11
query12 0.16 0.12 0.12
query13 0.62 0.61 0.60
query14 1.00 1.00 0.99
query15 0.86 0.83 0.83
query16 0.39 0.40 0.40
query17 1.05 1.05 1.05
query18 0.21 0.20 0.20
query19 1.94 1.84 1.83
query20 0.02 0.02 0.01
query21 15.81 0.19 0.13
query22 4.96 0.18 0.04
query23 15.44 0.26 0.10
query24 3.86 0.52 0.64
query25 0.08 0.07 0.06
query26 0.15 0.15 0.14
query27 0.07 0.06 0.06
query28 4.94 1.15 0.93
query29 12.54 3.91 3.16
query30 0.29 0.14 0.11
query31 2.83 0.58 0.39
query32 3.23 0.57 0.47
query33 3.10 3.07 3.06
query34 15.73 5.14 4.58
query35 4.61 4.63 4.60
query36 0.70 0.51 0.49
query37 0.13 0.07 0.07
query38 0.08 0.05 0.04
query39 0.05 0.03 0.03
query40 0.20 0.14 0.14
query41 0.11 0.03 0.03
query42 0.06 0.03 0.03
query43 0.06 0.04 0.03
Total cold run time: 100.22 s
Total hot run time: 27.7 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](inverted index) fix fs set when meet segment corruption [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58317:
URL: https://github.com/apache/doris/pull/58317#issuecomment-3578579967
# BE UT Coverage Report
Increment line coverage `57.14% (4/7)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/81c4eb2331b7fdfec679766214b6b6ec8fd8a151_81c4eb2331b7fdfec679766214b6b6ec8fd8a151/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/81c4eb2331b7fdfec679766214b6b6ec8fd8a151_81c4eb2331b7fdfec679766214b6b6ec8fd8a151/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.85% (18422/34858) |
| Line Coverage | 38.35% (168379/439102) |
| Region Coverage | 33.15% (130737/394397) |
| Branch Coverage | 34.10% (56251/164947) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org