You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/11 19:20:46 UTC

[GitHub] [spark] tanelk commented on pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

tanelk commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-796980570


   @karuppayya , could you add the benchmark results to the PR as a file in `sql/core/benchmarks/`.
   You can generate it like this (copied form the `JoinBenchmark` docstring):
   ``` 
   *   3. generate result:
    *      SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain <this class>"
    *      Results will be written to "benchmarks/JoinBenchmark-results.txt".
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org