You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "xxzuo (via GitHub)" <gi...@apache.org> on 2024/04/09 11:51:51 UTC
[PR] [Fix][Doc] Fixed links in some documents [seatunnel]
xxzuo opened a new pull request, #6673:
URL: https://github.com/apache/seatunnel/pull/6673
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
### Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
- Reference links have been added to the English document
- Replace some English document links in Chinese documents with translated Chinese document links
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
-->
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Doc] Fixed links in some documents [seatunnel]
Posted by "xxzuo (via GitHub)" <gi...@apache.org>.
xxzuo commented on PR #6673:
URL: https://github.com/apache/seatunnel/pull/6673#issuecomment-2046305902
> @EricJoy2048 @liugddx Sorry to bother, I have a question. I added a documentation link [debezium documentation](https://debezium.io/documentation/reference/2.5/connectors/mysql.html#mysql-events) in this PR, which is accessible, but it shows "dead links" in this GitHub Action.
> @EricJoy2048 @liugddx Sorry to bother, I have a question. I added a documentation link [debezium documentation](https://debezium.io/documentation/reference/2.5/connectors/mysql.html#mysql-events) in this PR, which is accessible, but it shows "dead links" in this GitHub Action.
Sorry, I added extra parentheses. Please ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Doc] Fixed links in some documents [seatunnel]
Posted by "xxzuo (via GitHub)" <gi...@apache.org>.
xxzuo commented on PR #6673:
URL: https://github.com/apache/seatunnel/pull/6673#issuecomment-2045222396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Doc] Fixed links in some documents [seatunnel]
Posted by "xxzuo (via GitHub)" <gi...@apache.org>.
xxzuo commented on code in PR #6673:
URL: https://github.com/apache/seatunnel/pull/6673#discussion_r1559380573
##########
docs/zh/connector-v2/source/HdfsFile.md:
##########
@@ -10,15 +10,15 @@
## 主要特性
-- [x] [批处理](../../../en/concept/connector-v2-features.md)
-- [ ] [流处理](../../../en/concept/connector-v2-features.md)
-- [x] [精确一次](../../../en/concept/connector-v2-features.md)
+- [x] [批处理](../../concept/connector-v2-features.md)
+- [ ] [流处理](../../concept/connector-v2-features.md)
+- [x] [精确一次](../../concept/connector-v2-features.md)
在一次 pollNext 调用中读取分片中的所有数据。将读取的分片保存在快照中。
-- [x] [列投影](../../../en/concept/connector-v2-features.md)
-- [x] [并行度](../../../en/concept/connector-v2-features.md)
-- [ ] [支持用户定义的分片](../../../en/concept/connector-v2-features.md)
Review Comment:
Thank you for your review. The website is an English document, will my modifications to the Chinese document also have an impact?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Doc] Fixed links in some documents [seatunnel]
Posted by "xxzuo (via GitHub)" <gi...@apache.org>.
xxzuo commented on code in PR #6673:
URL: https://github.com/apache/seatunnel/pull/6673#discussion_r1560388362
##########
docs/zh/connector-v2/source/HdfsFile.md:
##########
@@ -10,15 +10,15 @@
## 主要特性
-- [x] [批处理](../../../en/concept/connector-v2-features.md)
-- [ ] [流处理](../../../en/concept/connector-v2-features.md)
-- [x] [精确一次](../../../en/concept/connector-v2-features.md)
+- [x] [批处理](../../concept/connector-v2-features.md)
+- [ ] [流处理](../../concept/connector-v2-features.md)
+- [x] [精确一次](../../concept/connector-v2-features.md)
在一次 pollNext 调用中读取分片中的所有数据。将读取的分片保存在快照中。
-- [x] [列投影](../../../en/concept/connector-v2-features.md)
-- [x] [并行度](../../../en/concept/connector-v2-features.md)
-- [ ] [支持用户定义的分片](../../../en/concept/connector-v2-features.md)
Review Comment:
Yes, I replaced the associated document link here with the translated Chinese document link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Doc] Fixed links in some documents [seatunnel]
Posted by "xxzuo (via GitHub)" <gi...@apache.org>.
xxzuo commented on PR #6673:
URL: https://github.com/apache/seatunnel/pull/6673#issuecomment-2045218635
@EricJoy2048 @liugddx Sorry to bother, I have a question. I added a documentation link [debezium documentation](https://debezium.io/documentation/reference/2.5/connectors/mysql.html#mysql-events) in this PR, which is accessible, but it shows "dead links" in this GitHub Action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Doc] Fixed links in some documents [seatunnel]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #6673:
URL: https://github.com/apache/seatunnel/pull/6673#discussion_r1559387354
##########
docs/zh/connector-v2/source/HdfsFile.md:
##########
@@ -10,15 +10,15 @@
## 主要特性
-- [x] [批处理](../../../en/concept/connector-v2-features.md)
-- [ ] [流处理](../../../en/concept/connector-v2-features.md)
-- [x] [精确一次](../../../en/concept/connector-v2-features.md)
+- [x] [批处理](../../concept/connector-v2-features.md)
+- [ ] [流处理](../../concept/connector-v2-features.md)
+- [x] [精确一次](../../concept/connector-v2-features.md)
在一次 pollNext 调用中读取分片中的所有数据。将读取的分片保存在快照中。
-- [x] [列投影](../../../en/concept/connector-v2-features.md)
-- [x] [并行度](../../../en/concept/connector-v2-features.md)
-- [ ] [支持用户定义的分片](../../../en/concept/connector-v2-features.md)
Review Comment:
Oh, sorry about that. I missed this is chinese file. Are you verified in local with this change? Does it work fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Doc] Fixed links in some documents [seatunnel]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #6673:
URL: https://github.com/apache/seatunnel/pull/6673#discussion_r1559338859
##########
docs/zh/connector-v2/source/HdfsFile.md:
##########
@@ -10,15 +10,15 @@
## 主要特性
-- [x] [批处理](../../../en/concept/connector-v2-features.md)
-- [ ] [流处理](../../../en/concept/connector-v2-features.md)
-- [x] [精确一次](../../../en/concept/connector-v2-features.md)
+- [x] [批处理](../../concept/connector-v2-features.md)
+- [ ] [流处理](../../concept/connector-v2-features.md)
+- [x] [精确一次](../../concept/connector-v2-features.md)
在一次 pollNext 调用中读取分片中的所有数据。将读取的分片保存在快照中。
-- [x] [列投影](../../../en/concept/connector-v2-features.md)
-- [x] [并行度](../../../en/concept/connector-v2-features.md)
-- [ ] [支持用户定义的分片](../../../en/concept/connector-v2-features.md)
Review Comment:
Please do not change this. It work fine in website. You can refer https://seatunnel.apache.org/docs/2.3.4/connector-v2/source/HdfsFile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Doc] Fixed links in some documents [seatunnel]
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 merged PR #6673:
URL: https://github.com/apache/seatunnel/pull/6673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org