You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/28 08:55:22 UTC
[GitHub] [shardingsphere] jiangML opened a new pull request, #21826: Adjust 'SHOW READWRITE_ SPLITTING RULES' output column names and update doc about DistSQL
jiangML opened a new pull request, #21826:
URL: https://github.com/apache/shardingsphere/pull/21826
for #21780
Changes proposed in this pull request:
- change `write_data_source_name` to `write_storage_unit_name`
- change `read_data_source_names` to `read_storage_unit_names`
- update doc about DistSQL
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #21826: Adjust 'SHOW READWRITE_ SPLITTING RULES' output column names and update doc about DistSQL
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #21826:
URL: https://github.com/apache/shardingsphere/pull/21826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21826: Adjust 'SHOW READWRITE_ SPLITTING RULES' output column names and update doc about DistSQL
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21826:
URL: https://github.com/apache/shardingsphere/pull/21826#issuecomment-1294860175
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21826?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21826](https://codecov.io/gh/apache/shardingsphere/pull/21826?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4aeb7be) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a511f8e5f15661620402dce1237815d4239324d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a511f8e) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #21826 +/- ##
=========================================
Coverage 60.83% 60.83%
Complexity 2446 2446
=========================================
Files 4104 4104
Lines 57328 57328
Branches 9684 9684
=========================================
Hits 34878 34878
Misses 19549 19549
Partials 2901 2901
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...er/query/ReadwriteSplittingRuleQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/21826/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvcmVhZHdyaXRlLXNwbGl0dGluZy9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9kaXN0c3FsL2hhbmRsZXIvcXVlcnkvUmVhZHdyaXRlU3BsaXR0aW5nUnVsZVF1ZXJ5UmVzdWx0U2V0LmphdmE=) | `95.23% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org