You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/08/19 07:49:15 UTC
[GitHub] [ozone] Xushaohong opened a new pull request, #3697: HDDS-7150. Freon fail-at-end option caused not shutdown
Xushaohong opened a new pull request, #3697:
URL: https://github.com/apache/ozone/pull/3697
## What changes were proposed in this pull request?
Currently if turned on the fail-at-end option and the freon tasks have failures, `shotdown()` will be processed. It waits for the progress bar to be completed, while the progress bar will not naturally finish as there are failures. Thus the freon gets stuck.
```
if (failureCounter.get() > 0 && !failAtEnd) {
progressBar.terminate();
} else {
progressBar.shutdown();
}
```
We shall simply remove the flag check here, when Freon goes into ```shutdown```, it has processed all tasks in waitForCompletion().
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7150
## How was this patch tested?
Manual test on the cluster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3697: HDDS-7150. Freon fail-at-end option caused not shutdown
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3697:
URL: https://github.com/apache/ozone/pull/3697#issuecomment-1221521027
Thanks @Xushaohong for the patch, @Galsza for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3697: HDDS-7150. Freon fail-at-end option caused not shutdown
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3697:
URL: https://github.com/apache/ozone/pull/3697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org