You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/07/08 03:38:34 UTC

[GitHub] [pulsar] jiazhai commented on a change in pull request #4676: Enable a self-contained build of the pulsar-cpp-client static library

jiazhai commented on a change in pull request #4676: Enable a self-contained build of the pulsar-cpp-client static library
URL: https://github.com/apache/pulsar/pull/4676#discussion_r300912269
 
 

 ##########
 File path: pulsar-client-cpp/CMakeLists.txt
 ##########
 @@ -33,6 +33,12 @@ MESSAGE(STATUS "BUILD_TESTS:  " ${BUILD_TESTS})
 option(BUILD_PYTHON_WRAPPER "Build Pulsar Python wrapper" ON)
 MESSAGE(STATUS "BUILD_PYTHON_WRAPPER:  " ${BUILD_PYTHON_WRAPPER})
 
+option(BUILD_PERF "Build with Rate Limiter" ON)
 
 Review comment:
   Seems the comments ("Build with Rate Limiter") not aligned with BUILD_PERF

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services