You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Colm Rice (JIRA)" <ji...@apache.org> on 2012/10/19 15:14:11 UTC

[jira] [Created] (LUCENE-4494) Add phoenetic algorithm Match Rating approach to lucene

Colm Rice created LUCENE-4494:
---------------------------------

             Summary: Add phoenetic algorithm Match Rating approach to lucene
                 Key: LUCENE-4494
                 URL: https://issues.apache.org/jira/browse/LUCENE-4494
             Project: Lucene - Core
          Issue Type: Improvement
          Components: modules/analysis
    Affects Versions: 4.0-ALPHA
            Reporter: Colm Rice
            Priority: Minor
             Fix For: 4.1


I want to add MatchRatingApproach algorithm to the Lucene project. 

What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests

It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.

FYI: It my first contribitution so be gentle :-) C# is my native.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4494) Add phoenetic algorithm Match Rating approach to lucene

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480072#comment-13480072 ] 

Steven Rowe commented on LUCENE-4494:
-------------------------------------

Hi Colm, welcome!

Have you seen [http://wiki.apache.org/lucene-java/HowToContribute]?
                
> Add phoenetic algorithm Match Rating approach to lucene
> -------------------------------------------------------
>
>                 Key: LUCENE-4494
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4494
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.0-ALPHA
>            Reporter: Colm Rice
>            Priority: Minor
>             Fix For: 4.1
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project. 
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribitution so be gentle :-) C# is my native.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4494) Add phoenetic algorithm Match Rating approach to lucene

Posted by "Colm Rice (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481271#comment-13481271 ] 

Colm Rice commented on LUCENE-4494:
-----------------------------------

Thanks Steve. Glad to be able to contribute. The first of many :-)
Thanks for the link, I'll swot up on it.

Hi Lance, yes that's the one. I wrote that article btw!
                
> Add phoenetic algorithm Match Rating approach to lucene
> -------------------------------------------------------
>
>                 Key: LUCENE-4494
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4494
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.0-ALPHA
>            Reporter: Colm Rice
>            Priority: Minor
>             Fix For: 4.1
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project. 
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribitution so be gentle :-) C# is my native.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4494) Add phoenetic algorithm Match Rating approach to lucene

Posted by "Lance Norskog (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480615#comment-13480615 ] 

Lance Norskog commented on LUCENE-4494:
---------------------------------------

Cool! Is it this algorithm? 
[http://en.wikipedia.org/wiki/Match_rating_approach]


                
> Add phoenetic algorithm Match Rating approach to lucene
> -------------------------------------------------------
>
>                 Key: LUCENE-4494
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4494
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.0-ALPHA
>            Reporter: Colm Rice
>            Priority: Minor
>             Fix For: 4.1
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project. 
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribitution so be gentle :-) C# is my native.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-4494) Add phoenetic algorithm Match Rating approach to lucene

Posted by "Colm Rice (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colm Rice resolved LUCENE-4494.
-------------------------------

    Resolution: Fixed

Reloacted to CODEC-161 as its more current. Added associated patch there.
                
> Add phoenetic algorithm Match Rating approach to lucene
> -------------------------------------------------------
>
>                 Key: LUCENE-4494
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4494
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.0-ALPHA
>            Reporter: Colm Rice
>            Priority: Minor
>             Fix For: 4.1
>
>         Attachments: LUCENE-4494.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project. 
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribitution so be gentle :-) C# is my native.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4494) Add phoenetic algorithm Match Rating approach to lucene

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482476#comment-13482476 ] 

Ryan McKinley commented on LUCENE-4494:
---------------------------------------

This looks great -- though it seems like the more appropriate home is in commons codec:
http://commons.apache.org/codec/api-release/org/apache/commons/codec/language/package-summary.html

                
> Add phoenetic algorithm Match Rating approach to lucene
> -------------------------------------------------------
>
>                 Key: LUCENE-4494
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4494
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.0-ALPHA
>            Reporter: Colm Rice
>            Priority: Minor
>             Fix For: 4.1
>
>         Attachments: LUCENE-4494.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project. 
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribitution so be gentle :-) C# is my native.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4494) Add phoenetic algorithm Match Rating approach to lucene

Posted by "Colm Rice (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483108#comment-13483108 ] 

Colm Rice commented on LUCENE-4494:
-----------------------------------

Hi Ryan, yes, your right of course. In short, if I knew how to do it I would, I'm still a bit of a newbie you see!
I received some advice previously (not sure how good it was now) that indicated that the codecs are rarely touched, so I decided to add the patch to the Lucene solution and hope that someone with more experience that I, would do some handholding with me or relocate it.
Je suis desole :-)
                
> Add phoenetic algorithm Match Rating approach to lucene
> -------------------------------------------------------
>
>                 Key: LUCENE-4494
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4494
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.0-ALPHA
>            Reporter: Colm Rice
>            Priority: Minor
>             Fix For: 4.1
>
>         Attachments: LUCENE-4494.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project. 
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribitution so be gentle :-) C# is my native.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4494) Add phoenetic algorithm Match Rating approach to lucene

Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Otis Gospodnetic updated LUCENE-4494:
-------------------------------------

    Description: 
I want to add MatchRatingApproach algorithm to the Lucene project. 

What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests

It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.

FYI: It my first contribitution so be gentle :-) C# is my native.

Reference: http://en.wikipedia.org/wiki/Match_rating_approach

  was:
I want to add MatchRatingApproach algorithm to the Lucene project. 

What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests

It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.

FYI: It my first contribitution so be gentle :-) C# is my native.

    
> Add phoenetic algorithm Match Rating approach to lucene
> -------------------------------------------------------
>
>                 Key: LUCENE-4494
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4494
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.0-ALPHA
>            Reporter: Colm Rice
>            Priority: Minor
>             Fix For: 4.1
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project. 
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribitution so be gentle :-) C# is my native.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4494) Add phoenetic algorithm Match Rating approach to lucene

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483418#comment-13483418 ] 

Ryan McKinley commented on LUCENE-4494:
---------------------------------------

Your patch looks good as is.  With the tests and docs you have, I expect it will easily slide into commons codec.

re 'codecs are rarely touched'
I expect they do not *change* them often (ever?), but adding a new generally useful codec is what the project is for!

Nothing in the patch relies on lucene -- I suggest making a patch just like this one and posting it here:
https://issues.apache.org/jira/browse/CODEC

Just take what you have and replace:
{code}lucene/analysis/phonetic/src/test/org/apache/lucene/analysis/phonetic/{code}
with
{code}src/main/java/org/apache/commons/codec/language/{code}
and you should be good.

Let me know if you need help 
                
> Add phoenetic algorithm Match Rating approach to lucene
> -------------------------------------------------------
>
>                 Key: LUCENE-4494
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4494
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.0-ALPHA
>            Reporter: Colm Rice
>            Priority: Minor
>             Fix For: 4.1
>
>         Attachments: LUCENE-4494.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project. 
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribitution so be gentle :-) C# is my native.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4494) Add phoenetic algorithm Match Rating approach to lucene

Posted by "Colm Rice (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colm Rice updated LUCENE-4494:
------------------------------

    Attachment: LUCENE-4494.patch

Match Rating Approach (MRA) phonetic algorithm & associated tests. 
I hope... 

:-)
                
> Add phoenetic algorithm Match Rating approach to lucene
> -------------------------------------------------------
>
>                 Key: LUCENE-4494
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4494
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.0-ALPHA
>            Reporter: Colm Rice
>            Priority: Minor
>             Fix For: 4.1
>
>         Attachments: LUCENE-4494.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project. 
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribitution so be gentle :-) C# is my native.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4494) Add phoenetic algorithm Match Rating approach to lucene

Posted by "Colm Rice (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484831#comment-13484831 ] 

Colm Rice commented on LUCENE-4494:
-----------------------------------

Thanks Ryan for the newbie assist, your a star. I have added that patch to CODEC-161. 
I'm going to close this issue as 161 is just more current.
Cheers.
                
> Add phoenetic algorithm Match Rating approach to lucene
> -------------------------------------------------------
>
>                 Key: LUCENE-4494
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4494
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.0-ALPHA
>            Reporter: Colm Rice
>            Priority: Minor
>             Fix For: 4.1
>
>         Attachments: LUCENE-4494.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project. 
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribitution so be gentle :-) C# is my native.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org