You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/31 14:13:07 UTC

[GitHub] [beam] riteshghorse commented on a diff in pull request #22941: Allows to use databaseio with postgres driver

riteshghorse commented on code in PR #22941:
URL: https://github.com/apache/beam/pull/22941#discussion_r959633051


##########
sdks/go/pkg/beam/io/databaseio/writer_test.go:
##########
@@ -0,0 +1,33 @@
+package databaseio
+
+import "testing"
+
+func TestValueTemplateGenerator(t *testing.T) {

Review Comment:
   Since you have multiple test cases for this function, we usually do it in a table-format as written in the example: https://github.com/apache/beam/blob/d615b624e9ff211e857d026d541c4d56fd18e2d3/sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange_test.go#L30
   
   Just to keep it consistent, could you format it like the one in link above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org