[GitHub] [arrow-datafusion] yjshen commented on a diff in pull request #2215: Remove tokio::spawn from HashAggregateExec (#2201)

[GitBox <gi...@apache.org>]

yjshen commented on code in PR #2215:
URL: https://github.com/apache/arrow-datafusion/pull/2215#discussion_r848994986


##########
datafusion/core/src/physical_plan/hash_aggregate.rs:
##########
@@ -748,46 +732,15 @@ fn aggregate_expressions(
     }
 }
 
-pin_project! {
-    /// stream struct for hash aggregation
-    pub struct HashAggregateStream {
-        schema: SchemaRef,
-        #[pin]
-        output: futures::channel::oneshot::Receiver<ArrowResult<RecordBatch>>,
-        finished: bool,
-        drop_helper: AbortOnDropSingle<()>,
-    }
-}
-
-/// Special case aggregate with no groups
-async fn compute_hash_aggregate(
-    mode: AggregateMode,
+/// stream struct for hash aggregation
+pub struct HashAggregateStream {

Review Comment:
   `Hash` makes no sense each time I saw it 🙃



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org