[GitHub] [flink-connector-elasticsearch] fapaul commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles

[GitBox <gi...@apache.org>]

fapaul commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r863795387


##########
pom.xml:
##########
@@ -806,32 +436,6 @@ under the License.
 							<artifactId>maven-shade-plugin</artifactId>
 							<version>3.2.4</version>
 						</plugin>
-						<plugin>
-							<groupId>com.github.siom79.japicmp</groupId>
-							<artifactId>japicmp-maven-plugin</artifactId>

Review Comment:
   Did you remove the japicmp plugin intentionally? 



##########
pom.xml:
##########
@@ -393,67 +338,13 @@ under the License.
 				<version>3.3.2</version>
 			</dependency>
 
-			<dependency>
-				<groupId>org.xerial.snappy</groupId>
-				<artifactId>snappy-java</artifactId>
-				<version>1.1.8.3</version>
-			</dependency>
-
-			<dependency>
-				<groupId>org.lz4</groupId>
-				<artifactId>lz4-java</artifactId>
-				<version>${lz4.version}</version>
-			</dependency>
-
-			<dependency>
-				<groupId>com.github.oshi</groupId>
-				<artifactId>oshi-core</artifactId>
-				<version>3.4.0</version>
-			</dependency>
-
-			<!-- We no longer align the avro version with the version bundled in Hadoop.
-			 Users might need to downgrade the avro version for a particular Hadoop version. -->
-			<dependency>
-				<groupId>org.apache.avro</groupId>
-				<artifactId>avro</artifactId>
-				<version>${avro.version}</version>
-			</dependency>
-
 			<!-- For dependency convergence -->
 			<dependency>

Review Comment:
   Nit: Do we still need hamcrest? I hoped all assertions are migrated to assertJ by now.



##########
pom.xml:
##########
@@ -1556,78 +1000,6 @@ under the License.
 							</rules>
 						</configuration>
 					</execution>
-					<execution>
-						<id>ban-unsafe-snakeyaml</id>
-						<goals>

Review Comment:
   Did you verify that the connector does not use jackson, snakeyaml or uses versions that are not vulnerable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org