You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@apache.org> on 2013/01/24 03:51:22 UTC
Review Request: FLUME-1872: SpoolingDirectorySource doesn't delete tracker
file when deletePolicy is "immediate"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9080/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Fix issue where tracker file is not deleted when deletePolicy is set to "immediate" for spooled files.
This addresses bug FLUME-1872.
https://issues.apache.org/jira/browse/FLUME-1872
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java b19d0ea
flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java a29606e
Diff: https://reviews.apache.org/r/9080/diff/
Testing
-------
Added unit test. Unit tests pass.
Thanks,
Mike Percy
Re: Review Request: FLUME-1872: SpoolingDirectorySource doesn't delete
tracker file when deletePolicy is "immediate"
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9080/#review15711
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On Jan. 24, 2013, 2:51 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9080/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 2:51 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Fix issue where tracker file is not deleted when deletePolicy is set to "immediate" for spooled files.
>
>
> This addresses bug FLUME-1872.
> https://issues.apache.org/jira/browse/FLUME-1872
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java b19d0ea
> flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java a29606e
>
> Diff: https://reviews.apache.org/r/9080/diff/
>
>
> Testing
> -------
>
> Added unit test. Unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>
Re: Review Request: FLUME-1872: SpoolingDirectorySource doesn't delete
tracker file when deletePolicy is "immediate"
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9080/#review15707
-----------------------------------------------------------
Looks good, running tests.
- Brock Noland
On Jan. 24, 2013, 2:51 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9080/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 2:51 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Fix issue where tracker file is not deleted when deletePolicy is set to "immediate" for spooled files.
>
>
> This addresses bug FLUME-1872.
> https://issues.apache.org/jira/browse/FLUME-1872
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java b19d0ea
> flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java a29606e
>
> Diff: https://reviews.apache.org/r/9080/diff/
>
>
> Testing
> -------
>
> Added unit test. Unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>