[GH] (pekko/fix-loggerclass-jdk25-1.7.x): Workflow run "Pull Requests" failed!

[GitBox <gi...@apache.org>]

The GitHub Actions job "Pull Requests" on pekko.git/fix-loggerclass-jdk25-1.7.x has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
0102404193b083e6293132d1f8db7a58ad9c9bbb / PJ Fanning <pj...@users.noreply.github.com>
fix: detect logger class with StackWalker on JDK 9+ in 1.7.x

Motivation:
On JDK 25 with Scala 3, ctx.log picks the enclosing outer object as the
logger class instead of the lambda owner. SecurityManager.getClassContext
does not report the hidden lambda frames there, so the Scala 3 lambda
owner detection in LoggerClass never matches. The JDK 25 / Scala 3.3.x
job of the 1.7 nightly fails in EventSourcedBehaviorLoggingSpec.

Modification:
Read the class stack with java.lang.StackWalker (RETAIN_CLASS_REFERENCE,
SHOW_HIDDEN_FRAMES) when available, through reflection since 1.7.x is
compiled for Java 8. Fall back to the SecurityManager approach on Java 8.

Result:
Logger class detection works on JDK 25 with Scala 3, matching main which
already uses StackWalker.

Tests:
- JDK 25 + Scala 3.3.7: EventSourcedBehaviorLogging* specs fail before (5 failures), pass after; ActorLoggingSpec passes
- JDK 8 + Scala 2.13: EventSourcedBehaviorLogging* specs and ActorLoggingSpec pass
- actor-typed/mimaReportBinaryIssues: no issues

References:
None - fixes the JDK 25 / Scala 3.3.x failure in the Nightly Builds (1.7) workflow

Report URL: https://github.com/apache/pekko/actions/runs/38040524001

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org