You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Kristen Legacy <kl...@theatomgroup.com> on 2012/04/27 23:07:15 UTC

Review Request: RAVE-574

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4917/
-----------------------------------------------------------

Review request for rave.


Summary
-------

Added bootstrap classes & markup to error page. Also removed inline show/hide on error stack and replaced with slideToggle. I wasn't sure which script file it should live in & didn't want to cramp the organization style so I've left the function in error.jps


Diffs
-----

  trunk/rave-portal-resources/src/main/webapp/css/default.css 1331562 
  trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/error.jsp 1331562 

Diff: https://reviews.apache.org/r/4917/diff


Testing
-------


Thanks,

Kristen

Re: Review Request: RAVE-574

Posted by mf...@apache.org.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4917/#review7368
-----------------------------------------------------------

Ship it!


Looks pretty good.  Only one inconsequential question.


trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/error.jsp
<https://reviews.apache.org/r/4917/#comment16253>

    Curious, why do you replace the HTML rather than hide the element?


- mfranklin


On 2012-04-27 21:07:15, Kristen Legacy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4917/
> -----------------------------------------------------------
> 
> (Updated 2012-04-27 21:07:15)
> 
> 
> Review request for rave.
> 
> 
> Summary
> -------
> 
> Added bootstrap classes & markup to error page. Also removed inline show/hide on error stack and replaced with slideToggle. I wasn't sure which script file it should live in & didn't want to cramp the organization style so I've left the function in error.jps
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/webapp/css/default.css 1331562 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/error.jsp 1331562 
> 
> Diff: https://reviews.apache.org/r/4917/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kristen
> 
>