You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by Esquive <gi...@git.apache.org> on 2017/01/19 13:00:38 UTC

[GitHub] twill pull request #24: Twill 90

GitHub user Esquive opened a pull request:

    https://github.com/apache/twill/pull/24

    Twill 90

    Hello, 
    
    for a project I required the capability to set the resources of the YARN application Manager. In the solution I propose I did not break the API all the Builders are extended to support the following AM resources: MEM and CPU cores. I extended the TwillSpecification classes to accept the said parameters. I did not create a dedicated "TwillAMSpecification" subclass as AM is also a "TwillRunnable".
    
    Cheers

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Esquive/twill TWILL-90

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/twill/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 3bd7326f665fb0af76971207a0e3e9db1a2d837e
Author: Eric <er...@gmail.com>
Date:   2016-09-11T15:21:36Z

    AM resources are now parameters

commit dcaf7f29f2b471e7ab55bb74314dcd787f5ad255
Author: Esquive <er...@uni.lu>
Date:   2017-01-19T10:41:59Z

    Modififed the indents from spaces to tab

commit 74f1e95a9350ff40ff71ac88e58809d689bfe4c2
Author: Esquive <er...@uni.lu>
Date:   2017-01-19T10:43:54Z

    Reverted the indent to spaces

commit 7619b0bcea6d9d7491cfbf95f89dabd13dc70969
Author: Esquive <er...@uni.lu>
Date:   2017-01-19T12:53:44Z

    Removed commented code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #24: Twill 90

Posted by Esquive <gi...@git.apache.org>.
Github user Esquive closed the pull request at:

    https://github.com/apache/twill/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill issue #24: Twill 90

Posted by chtyim <gi...@git.apache.org>.
Github user chtyim commented on the issue:

    https://github.com/apache/twill/pull/24
  
    Please use 2 spaces instead of 4 for indentation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---