You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/04 00:11:54 UTC

[GitHub] [superset] betodealmeida commented on a change in pull request #13441: chore: refactor on DBEventLogger to allow for context management

betodealmeida commented on a change in pull request #13441:
URL: https://github.com/apache/superset/pull/13441#discussion_r586909918



##########
File path: superset/utils/log.py
##########
@@ -133,8 +155,29 @@ def log_context(  # pylint: disable=too-many-locals
             records=records,
             dashboard_id=dashboard_id,
             slice_id=slice_id,
-            duration_ms=round((time.time() - start_time) * 1000),
+            duration_ms=duration,

Review comment:
       We need to convert to int:
   
   ```suggestion
               duration_ms=duration.total_seconds() * 1000,
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org