[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

["Amogh Margoor (Code Review)" <ge...@cloudera.org>]

Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 )

Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library
......................................................................


Patch Set 8:

> (1 comment)
So '-' would reach as an empty string here - the reason being signs are stripped off before sending it to the library. But anyways I think you are talking about pointer to one past the end of array. So AFAIK C++ standard allows pointer to point to either any elements of array or one past the end of elements - thats how STL Iterator end() are implemented too. But I think dereferencing such pointer is an undefined behaviour. So probably we cannot check if incoming string is already null-terminated and should always take care of making a copy and null-terminating it.


-- 
To view, visit http://gerrit.cloudera.org:8080/17389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic105ad38a2fcbf2fb4e8ae8af6d9a8e251a9c141
Gerrit-Change-Number: 17389
Gerrit-PatchSet: 8
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Aug 2021 14:23:07 +0000
Gerrit-HasComments: No