You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/20 05:53:44 UTC

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #4381: modify parsing result for insert sql

tristaZero opened a new pull request #4381: modify parsing result for insert sql
URL: https://github.com/apache/incubator-shardingsphere/pull/4381
 
 
   Fixes #4380.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4381: modify parsing result for insert sql

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4381: modify parsing result for insert sql
URL: https://github.com/apache/incubator-shardingsphere/pull/4381#issuecomment-588630315
 
 
   ## Pull Request Test Coverage Report for [Build 1816](https://coveralls.io/builds/28845884)
   
   * **0** of **5**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.01%**) to **56.997%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDMLVisitor.java](https://coveralls.io/builds/28845884/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerDMLVisitor.java#L109) | 0 | 5 | 0.0%
   <!-- | **Total:** | **0** | **5** | **0.0%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28845884/badge)](https://coveralls.io/builds/28845884) |
   | :-- | --: |
   | Change from base [Build 888](https://coveralls.io/builds/28844646): |  -0.01% |
   | Covered Lines: | 11030 |
   | Relevant Lines: | 19352 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl merged pull request #4381: modify parsing result for insert sql

Posted by GitBox <gi...@apache.org>.
dongzl merged pull request #4381: modify parsing result for insert sql
URL: https://github.com/apache/incubator-shardingsphere/pull/4381
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4381: modify parsing result for insert sql

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4381: modify parsing result for insert sql
URL: https://github.com/apache/incubator-shardingsphere/pull/4381#issuecomment-588630315
 
 
   ## Pull Request Test Coverage Report for [Build 9662](https://coveralls.io/builds/28845863)
   
   * **0** of **5**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.02%**) to **56.992%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDMLVisitor.java](https://coveralls.io/builds/28845863/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerDMLVisitor.java#L109) | 0 | 5 | 0.0%
   <!-- | **Total:** | **0** | **5** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28845863/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28845863/badge)](https://coveralls.io/builds/28845863) |
   | :-- | --: |
   | Change from base [Build 888](https://coveralls.io/builds/28844646): |  -0.02% |
   | Covered Lines: | 11029 |
   | Relevant Lines: | 19352 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4381: modify parsing result for insert sql

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4381: modify parsing result for insert sql
URL: https://github.com/apache/incubator-shardingsphere/pull/4381#issuecomment-588629081
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4381?src=pr&el=h1) Report
   > Merging [#4381](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4381?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/26dce76c16889175d1b9048b463370485b333efc?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4381/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4381?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4381      +/-   ##
   ============================================
   - Coverage     53.55%   53.54%   -0.02%     
     Complexity      351      351              
   ============================================
     Files          1048     1048              
     Lines         19347    19352       +5     
     Branches       3562     3562              
   ============================================
     Hits          10362    10362              
   - Misses         8329     8334       +5     
     Partials        656      656
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4381?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/sql/parser/visitor/impl/SQLServerDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4381/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL2ltcGwvU1FMU2VydmVyRE1MVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4381?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4381?src=pr&el=footer). Last update [26dce76...d6d258c](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4381?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services