You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by "holgerfriedrich (via GitHub)" <gi...@apache.org> on 2025/09/29 22:39:49 UTC
[PR] Fix incomplete upgrade of commons-lang3 [karaf]
holgerfriedrich opened a new pull request, #2073:
URL: https://github.com/apache/karaf/pull/2073
This is required to get the use-base-version test in karaf-maven-plugin pass.
I don't know why the CI passed at that time.
This is the error the PR is fixing:
```
[INFO] junit.framework.AssertionFailedError: org.custommonkey.xmlunit.Diff
[different] Expected text value 'mvn:org.apache.commons/commons-lang3/3.4' but was 'mvn:org.apache.commons/commons-lang3/3.18.0' - comparing <bundle ...>mvn:org.apache.commons/commons-lang3/3.4</bundle> at /features[1]/feature[1]/bundle[1]/text()[1] to <bundle ...>mvn:org.apache.commons/commons-lang3/3.18.0</bundle> at /features[1]/feature[1]/bundle[1]/text()[1]
```
To see that this is the root cause, one needs to remove the try-catch blocks from the tests.
Then the tests prints the exception when failing.
I will create another PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix incomplete upgrade of commons-lang3 [karaf]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #2073:
URL: https://github.com/apache/karaf/pull/2073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix incomplete upgrade of commons-lang3 [karaf]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2073:
URL: https://github.com/apache/karaf/pull/2073#issuecomment-3350903501
Good catch. We actually have a problem on GitHub Action: it executes the tests, but not the itests. I'm fixing that in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org