You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/21 14:22:20 UTC
[GitHub] [apisix] starsz commented on a change in pull request #3621: ci: auto release and check for rpm
starsz commented on a change in pull request #3621:
URL: https://github.com/apache/apisix/pull/3621#discussion_r579813653
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +29,15 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
+ run: |
+ sudo gem install --no-document fpm
+ # WOULD CHANGE TO MASTER WHEN PR GETS MERGED
+ git clone https://github.com/idbeta/build-tools.git
Review comment:
IMO, we should wait for `https://github.com/api7/apisix-build-tools/pull/14` to be merged, and use `api7/apisix-build-tools`
##########
File path: .github/workflows/centos7-ci.yml
##########
@@ -29,6 +29,15 @@ jobs:
with:
submodules: recursive
+ - name: Build rpm package
+ run: |
+ sudo gem install --no-document fpm
+ # WOULD CHANGE TO MASTER WHEN PR GETS MERGED
+ git clone https://github.com/idbeta/build-tools.git
+ cd build-tools
+ git checkout new-method-to-package
Review comment:
We can use `-b` to specify the branch
Like
```
git clone -b new-method-to-package https://github.com/idbeta/build-tools.git
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org