[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #13092: [Bug] [Server] Once click online schedule time, task will be automatically scheduled

[GitBox <gi...@apache.org>]

DarkAssassinator commented on code in PR #13092:
URL: https://github.com/apache/dolphinscheduler/pull/13092#discussion_r1038970266


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/SchedulerServiceImpl.java:
##########
@@ -171,6 +171,9 @@ public Map<String, Object> insertSchedule(User loginUser,
         scheduleObj.setProcessDefinitionName(processDefinition.getName());
 
         ScheduleParam scheduleParam = JSONUtils.parseObject(schedule, ScheduleParam.class);
+        if (now.after(scheduleParam.getStartTime())) {
+            scheduleParam.setStartTime(now);
+        }

Review Comment:
   could we refactor to a private method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org