You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by jaydoane <gi...@git.apache.org> on 2017/03/27 06:59:13 UTC
[GitHub] couchdb-couch-log pull request #17: Fix dns timeout for undefined syslog hos...
GitHub user jaydoane opened a pull request:
https://github.com/apache/couchdb-couch-log/pull/17
Fix dns timeout for undefined syslog host
On some platforms, inet:getaddr can take several seconds to return when
passed the undefined atom, which is the default value of "syslog_host",
and therefore the value used when running tests. On platforms where it
takes longer to return than the test is allowed to run, the
couch_log_writer_syslog_test will fail with *timed out*.
This short circuits the case when "syslog_host" is undefined, and
removes the race from the test.
COUCHDB-3340
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch-log 3340-fix-dns-timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-log/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit 24112cf6ce9ed23029f7697b84548dc8acff28b5
Author: Jay Doane <ja...@gmail.com>
Date: 2017-03-27T06:46:15Z
Fix dns timeout for undefined syslog host
On some platforms, inet:getaddr can take several seconds to return when
passed the undefined atom, which is the default value of "syslog_host",
and therefore the value used when running tests. On platforms where it
takes longer to return than the test is allowed to run, the
couch_log_writer_syslog_test will fail with *timed out*.
This short circuits the case when "syslog_host" is undefined, and
removes the race from the test.
COUCHDB-3340
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log issue #17: Fix dns timeout for undefined syslog host
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on the issue:
https://github.com/apache/couchdb-couch-log/pull/17
@davisp do you mind taking a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log pull request #17: Fix dns timeout for undefined syslog hos...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch-log/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log issue #17: Fix dns timeout for undefined syslog host
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on the issue:
https://github.com/apache/couchdb-couch-log/pull/17
@iilyak @davisp thanks for the review. Can someone merge this for me?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log issue #17: Fix dns timeout for undefined syslog host
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the issue:
https://github.com/apache/couchdb-couch-log/pull/17
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log issue #17: Fix dns timeout for undefined syslog host
Posted by wohali <gi...@git.apache.org>.
Github user wohali commented on the issue:
https://github.com/apache/couchdb-couch-log/pull/17
TY @jaydoane !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---