You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by rr...@apache.org on 2019/06/14 14:38:24 UTC

[trafficserver] branch master updated: Removes checks for curl that snuck back into the tests

This is an automated email from the ASF dual-hosted git repository.

rrm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 3d8c450  Removes checks for curl that snuck back into the tests
3d8c450 is described below

commit 3d8c450e2c331f44b1c75615c928337051300c8c
Author: Randall Meyer <rr...@apache.org>
AuthorDate: Thu Jun 13 11:59:33 2019 -0700

    Removes checks for curl that snuck back into the tests
    
    These were removed in 6c1a90f4f209a02cf1345ac4c20e2e67c4c58db1
---
 tests/gold_tests/continuations/openclose_h2.test.py         | 5 ++---
 tests/gold_tests/pluginTest/cert_update/cert_update.test.py | 5 -----
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/tests/gold_tests/continuations/openclose_h2.test.py b/tests/gold_tests/continuations/openclose_h2.test.py
index 07aec81..a01a4bf 100644
--- a/tests/gold_tests/continuations/openclose_h2.test.py
+++ b/tests/gold_tests/continuations/openclose_h2.test.py
@@ -23,7 +23,6 @@ Test transactions and sessions over http2, making sure they open and close in th
 '''
 
 Test.SkipUnless(
-    Condition.HasProgram("curl", "Curl needs to be installed on system for this test to work"),
     Condition.HasCurlFeature('http2')
 )
 
@@ -98,7 +97,7 @@ tr.StillRunningAfter = ts
 # Parking this as a ready tester on a meaningless process
 # To stall the test runs that check for the stats until the
 # stats have propagated and are ready to read.
-def make_done_stat_ready(tsenv): 
+def make_done_stat_ready(tsenv):
   def done_stat_ready(process, hasRunFor, **kw):
     retval = subprocess.run("traffic_ctl metric get ssntxnorder_verify.test.done > done  2> /dev/null", shell=True, env=tsenv)
     if retval.returncode == 0:
@@ -106,7 +105,7 @@ def make_done_stat_ready(tsenv):
     return retval.returncode == 0
 
   return done_stat_ready
-  
+
 # number of sessions/transactions opened and closed are equal
 tr = Test.AddTestRun("Check Ssn order errors")
 server2.StartupTimeout = 60
diff --git a/tests/gold_tests/pluginTest/cert_update/cert_update.test.py b/tests/gold_tests/pluginTest/cert_update/cert_update.test.py
index ccd93d3..efabbc3 100644
--- a/tests/gold_tests/pluginTest/cert_update/cert_update.test.py
+++ b/tests/gold_tests/pluginTest/cert_update/cert_update.test.py
@@ -21,11 +21,6 @@ Test.Summary = '''
 Test cert_update plugin.
 '''
 
-# Check if curl --resolve and openssl exist
-Test.SkipUnless(
-    Condition.HasProgram("curl","Curl need to be installed on system for this test to work"),
-    Condition.HasCurlOption("--resolve")
-    )
 Test.SkipUnless(
     Condition.HasProgram("openssl","Openssl need to be installed on system for this test to work")
     )