You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/09 21:00:53 UTC
[GitHub] [pulsar] rdhabalia opened a new pull request #12703: Fix flaky test: PersistentTopicsTest::testPeekWithSubscriptionNameNotExist
rdhabalia opened a new pull request #12703:
URL: https://github.com/apache/pulsar/pull/12703
### Motivation
Flaky test was timing out because broker drops messages without sub and test waits forever to receive expected number of messages
```
Error: testPeekWithSubscriptionNameNotExist(org.apache.pulsar.broker.admin.PersistentTopicsTest) Time elapsed: 60.065 s <<< FAILURE!
org.apache.pulsar.client.api.PulsarClientException$TimeoutException: request timeout {'durationMs': '30000', 'reqId':'682754951081867712', 'remote':'localhost/127.0.0.1:40055', 'local':'/127.0.0.1:53962'}
at org.apache.pulsar.client.api.PulsarClientException.unwrap(PulsarClientException.java:1008)
at org.apache.pulsar.client.impl.ProducerBuilderImpl.create(ProducerBuilderImpl.java:91)
at org.apache.pulsar.broker.admin.PersistentTopicsTest.testPeekWithSubscriptionNameNotExist(PersistentTopicsTest.java:682)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #12703: Fix flaky test: PersistentTopicsTest::testPeekWithSubscriptionNameNotExist
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #12703:
URL: https://github.com/apache/pulsar/pull/12703#issuecomment-966158202
Hi @rdhabalia when submitting a PR, can you help provide a doc label (tick the box) in the [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation)? This helps others know more about the changes. Thanks
<img width="682" alt="Documentation" src="https://user-images.githubusercontent.com/50226895/141276155-c6adf3ad-c1e7-4cee-8e8f-5db8e7b3d21e.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia merged pull request #12703: Fix flaky test: PersistentTopicsTest::testPeekWithSubscriptionNameNotExist
Posted by GitBox <gi...@apache.org>.
rdhabalia merged pull request #12703:
URL: https://github.com/apache/pulsar/pull/12703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12703: Fix flaky test: PersistentTopicsTest::testPeekWithSubscriptionNameNotExist
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12703:
URL: https://github.com/apache/pulsar/pull/12703#issuecomment-964539436
@rdhabalia:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org