You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Uwe Schindler <uw...@thetaphi.de> on 2013/03/18 14:13:18 UTC

RE: svn commit: r1457734 - in /lucene/dev/trunk: ./ dev-tools/eclipse/dot.settings/ dev-tools/maven/ dev-tools/scripts/ lucene/ lucene/core/src/java/org/apache/lucene/util/ lucene/tools/javadoc/ lucene/tools/javadoc/java6/ lucene/tools/javadoc/java7/ solr

My fault, fixed.

I also removed reflection in IOUtils, as we are now on Java 7.

-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de


> -----Original Message-----
> From: Robert Muir [mailto:rcmuir@gmail.com]
> Sent: Monday, March 18, 2013 2:03 PM
> To: dev@lucene.apache.org
> Cc: commits@lucene.apache.org
> Subject: Re: svn commit: r1457734 - in /lucene/dev/trunk: ./ dev-
> tools/eclipse/dot.settings/ dev-tools/maven/ dev-tools/scripts/ lucene/
> lucene/core/src/java/org/apache/lucene/util/ lucene/tools/javadoc/
> lucene/tools/javadoc/java6/ lucene/tools/javadoc/java7/ solr
> 
> On Mon, Mar 18, 2013 at 8:28 AM,  <us...@apache.org> wrote:
> > Modified:
> > lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl
> > /XMLResponseParser.java
> > URL:
> > http://svn.apache.org/viewvc/lucene/dev/trunk/solr/solrj/src/java/org/
> >
> apache/solr/client/solrj/impl/XMLResponseParser.java?rev=1457734&r1=14
> > 57733&r2=1457734&view=diff
> >
> ==========================================================
> ============
> > ========
> > ---
> > lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl
> > /XMLResponseParser.java (original)
> > +++ lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/
> > +++ impl/XMLResponseParser.java Mon Mar 18 12:28:52 2013
> > @@ -55,6 +55,7 @@ public class XMLResponseParser extends R
> >    static {
> >      factory = XMLInputFactory.newInstance();
> >      try {
> > +      // nocommit: still true for 1.7?
> >        // The java 1.6 bundled stax parser (sjsxp) does not currently have a
> thread-safe
> >        // XMLInputFactory, as that implementation tries to cache and reuse
> the
> >        // XMLStreamReader.  Setting the parser-specific
> > "reuse-instance" property to false
> >
> 
> Thanks for taking the issue Uwe. There were still some nocommits in the
> patch, for xml-policeman review:
> 
> *
> solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimpo
> rt/XPathRecordReader.java
> *
> solr/core/src/java/org/apache/solr/handler/DocumentAnalysisRequestHand
> ler.java
> * solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
> *
> solr/solrj/src/java/org/apache/solr/client/solrj/impl/XMLResponseParser.jav
> a
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> commands, e-mail: dev-help@lucene.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org