You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/12/17 15:51:19 UTC
[GitHub] [incubator-pinot] grcevski opened a new pull request #4933: Fix
benchmark client
grcevski opened a new pull request #4933: Fix benchmark client
URL: https://github.com/apache/incubator-pinot/pull/4933
There's a bug in the PinotThroughput benchmark client, where if an exception happens while running a http request to the Pinot benchmark cluster, the driver will not close the connection and eventually we'll run out of socket handles. This bug seems to affect MacOS and Windows only.
The fix simply moves the httpRequest into a try region and consumes the response to simulate more accurate workload.
The benchmark cluster also seems to fail to start because of a NullPointerException in PinotHelixResourceManager. There's probably a better fix here, we'll need some help to do it properly. For now, so we can make progress we simply checked against the nullness of the instanceConfig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org