You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/13 15:59:06 UTC

[GitHub] [pulsar] Shoothzj opened a new pull request, #16581: Rename Pulsar txn metrics to specify OpenMetrics

Shoothzj opened a new pull request, #16581:
URL: https://github.com/apache/pulsar/pull/16581

   ### Motivation
   See https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md
   A COUNTER needs `metrics_name_total` or `metrics_name_created`
   
   This PR contains metric name broken changes.
   
   ### Modifications
   Rename counter's `_count` to `_total`
   
   ### metrics name broken changes
   - rename `pulsar_txn_committed_count` to `pulsar_txn_committed_total`
   - rename `pulsar_txn_aborted_count` to `pulsar_txn_aborted_total`
   - rename `pulsar_txn_created_count` to `pulsar_txn_created_total`
   - rename `pulsar_txn_timeout_count` to `pulsar_txn_timeout_total`
   - rename `pulsar_txn_append_log_count` to `pulsar_txn_append_log_total`
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [x] `doc-required` 
   As mentioned above, the metrics name has changed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #16581: Rename Pulsar txn metrics to specify OpenMetrics

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #16581:
URL: https://github.com/apache/pulsar/pull/16581#issuecomment-1185079656

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj merged pull request #16581: Rename Pulsar txn metrics to specify OpenMetrics

Posted by GitBox <gi...@apache.org>.
Shoothzj merged PR #16581:
URL: https://github.com/apache/pulsar/pull/16581


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #16581: Rename Pulsar txn metrics to specify OpenMetrics

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #16581:
URL: https://github.com/apache/pulsar/pull/16581#issuecomment-1184307469

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #16581: Rename Pulsar txn metrics to specify OpenMetrics

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #16581:
URL: https://github.com/apache/pulsar/pull/16581#issuecomment-1184220831

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #16581: Rename Pulsar txn metrics to specify OpenMetrics

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #16581:
URL: https://github.com/apache/pulsar/pull/16581#issuecomment-1185062404

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #16581: Rename Pulsar txn metrics to specify OpenMetrics

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #16581:
URL: https://github.com/apache/pulsar/pull/16581#issuecomment-1184220415

   @nicoloboschi I will follow up on this. Ensure all the metrics to be renamed before 2.11.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #16581: Rename Pulsar txn metrics to specify OpenMetrics

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #16581:
URL: https://github.com/apache/pulsar/pull/16581#issuecomment-1184577867

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #16581: Rename Pulsar txn metrics to specify OpenMetrics

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #16581:
URL: https://github.com/apache/pulsar/pull/16581#issuecomment-1184039004

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16581: Rename Pulsar txn metrics to specify OpenMetrics

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16581:
URL: https://github.com/apache/pulsar/pull/16581#issuecomment-1183415639

   @Shoothzj Please provide a correct documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org