You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-dev@hadoop.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2009/05/08 03:16:45 UTC

[jira] Commented: (HADOOP-5782) Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting patch

    [ https://issues.apache.org/jira/browse/HADOOP-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707201#action_12707201 ] 

Raghu Angadi commented on HADOOP-5782:
--------------------------------------

+1. After applying this patch, the first patch attached to HADOOP-5780 applies cleanly just by changing the file name from FSNamesystem.java to BlockManager.java.

IMHO personally,  the small block of code in metaSave() I looked at,  looks better with this patch :-)

I think this can committed without going through highly backlogged Hudson.. could you run test-patch yourself?

> Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting patch
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5782
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5782
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: formatting.patch
>
>
> When block management code was refactored from FSNamesystem.java to BlockManager.java, some formatting changes are made. These changes make porting patches to BlockManager.java difficult.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.