You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/07/10 14:46:31 UTC
[jira] Commented: (HARMONY-776) [classlib][nio] Refine several
methods of o.a.h.nio.internal.ServerSocketChannelImpl
[ http://issues.apache.org/jira/browse/HARMONY-776?page=comments#action_12420061 ]
Andrew Zhang commented on HARMONY-776:
--------------------------------------
Hello George,
The fix looks good, many thanks!
Best regards,
Andrew
> [classlib][nio] Refine several methods of o.a.h.nio.internal.ServerSocketChannelImpl
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-776
> URL: http://issues.apache.org/jira/browse/HARMONY-776
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Attachments: nio.diff
>
> Refine several methods of o.a.h.nio.internal.ServerSocketChannelImpl. The improvements include:
> 1. implConfgiureBlocking method: Remove an unnecessary operation as discussed on mailing-list. [1][2]
> 2. Remove an unnecessary condition check at line 116 and 231. if (!isBound || !socket.isBound()) checks bound redundantly,
> as "isBound" always returns the same value as "socket.isBound()".
> 3. Improve some javadoc for ServerSocketChannelImpl.
> I'll upload a patch soon.
> Thanks!
> Best regards,
> Andrew
> [1] Thread: Modify ServerSocketChannel.implConfigureBlocking() method
> [2] Thread: [continuum] BUILD FAILURE: Classlib/win.ia32 Build/Test (Jul 30)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira