You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "toby-bridges (via GitHub)" <gi...@apache.org> on 2026/05/17 04:10:05 UTC

[PR] fix: align regexp_instr empty-pattern behavior with PostgreSQL [datafusion]

toby-bridges opened a new pull request, #22288:
URL: https://github.com/apache/datafusion/pull/22288

   ## Summary
   - remove the `regexp_instr` empty-pattern special case that forced `0`
   - rely on the existing regex search path so non-empty strings return PostgreSQL-compatible 1-based positions for empty patterns
   - add scalar regression coverage and a sqllogictest case for `SELECT regexp_instr('abc', '')`
   
   Fixes #22257.
   
   ## Testing
   - `cargo test -p datafusion-functions regexp_instr`
   - `cargo test -p datafusion-sqllogictest --test sqllogictests -- regexp_instr.slt`
   - `cargo fmt --all --check`
   - `git diff --check`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: align regexp_instr empty-pattern behavior with PostgreSQL [datafusion]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22288:
URL: https://github.com/apache/datafusion/pull/22288#issuecomment-5081578408

   Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: align regexp_instr empty-pattern behavior with PostgreSQL [datafusion]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #22288: fix: align regexp_instr empty-pattern behavior with PostgreSQL
URL: https://github.com/apache/datafusion/pull/22288


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: align regexp_instr empty-pattern behavior with PostgreSQL [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #22288:
URL: https://github.com/apache/datafusion/pull/22288#issuecomment-4542124205

   We have an existing PR which seems to cover more edge cases:
   
   - https://github.com/apache/datafusion/pull/22286


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org