You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2022/12/11 20:21:53 UTC

[maven-surefire] branch SUREFIRE-2133 updated (fd6953bde -> 9f8b4b5ed)

This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a change to branch SUREFIRE-2133
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git


 discard fd6953bde [SUREFIRE-2133] Make anchors start *before* the headings
     new 9f8b4b5ed [SUREFIRE-2133] Make anchors start *before* the headings

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (fd6953bde)
            \
             N -- N -- N   refs/heads/SUREFIRE-2133 (9f8b4b5ed)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../plugins/surefire/report/SurefireReportGenerator.java    | 13 -------------
 1 file changed, 13 deletions(-)


[maven-surefire] 01/01: [SUREFIRE-2133] Make anchors start *before* the headings

Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a commit to branch SUREFIRE-2133
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git

commit 9f8b4b5ed7a9878c225a19fe4f746de1485b8b10
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Sun Dec 11 21:19:21 2022 +0100

    [SUREFIRE-2133] Make anchors start *before* the headings
    
    This closes #582
---
 .../surefire/report/SurefireReportGenerator.java      | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
index b4d9d2436..efea45e31 100644
--- a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
+++ b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
@@ -120,12 +120,11 @@ public final class SurefireReportGenerator
         Map<String, String> summary = report.getSummary( testSuites );
 
         sink.section1();
+        sinkAnchor( sink, "Summary" );
         sink.sectionTitle1();
         sink.text( bundle.getReportLabelSummary() );
         sink.sectionTitle1_();
 
-        sinkAnchor( sink, "Summary" );
-
         constructHotLinks( sink, bundle );
 
         sinkLineBreak( sink );
@@ -187,12 +186,11 @@ public final class SurefireReportGenerator
         NumberFormat numberFormat = report.getNumberFormat();
 
         sink.section1();
+        sinkAnchor( sink, "Package_List" );
         sink.sectionTitle1();
         sink.text( bundle.getReportLabelPackageList() );
         sink.sectionTitle1_();
 
-        sinkAnchor( sink, "Package_List" );
-
         constructHotLinks( sink, bundle );
 
         sinkLineBreak( sink );
@@ -263,12 +261,11 @@ public final class SurefireReportGenerator
             List<ReportTestSuite> testSuiteList = entry.getValue();
 
             sink.section2();
+            sinkAnchor( sink, packageName );
             sink.sectionTitle2();
             sink.text( packageName );
             sink.sectionTitle2_();
 
-            sinkAnchor( sink, packageName );
-
             boolean showTable = false;
 
             for ( ReportTestSuite suite : testSuiteList )
@@ -381,12 +378,11 @@ public final class SurefireReportGenerator
         NumberFormat numberFormat = report.getNumberFormat();
 
         sink.section1();
+        sinkAnchor( sink, "Test_Cases" );
         sink.sectionTitle1();
         sink.text( bundle.getReportLabelTestCases() );
         sink.sectionTitle1_();
 
-        sinkAnchor( sink, "Test_Cases" );
-
         constructHotLinks( sink, bundle );
 
         for ( ReportTestSuite suite : testSuites )
@@ -396,12 +392,11 @@ public final class SurefireReportGenerator
             if ( !testCases.isEmpty() )
             {
                 sink.section2();
+                sinkAnchor( sink, suite.getPackageName() + '.' + suite.getName() );
                 sink.sectionTitle2();
                 sink.text( suite.getName() );
                 sink.sectionTitle2_();
 
-                sinkAnchor( sink, suite.getPackageName() + '.' + suite.getName() );
-
                 boolean showTable = false;
 
                 for ( ReportTestCase testCase : testCases )
@@ -466,7 +461,6 @@ public final class SurefireReportGenerator
         if ( !testCase.isSuccessful() )
         {
             sink.tableCell();
-
             sinkAnchor( sink, "TC_" + toHtmlId( testCase.getFullName() ) );
 
             sinkLink( sink, testCase.getName(), "#" + toHtmlId( testCase.getFullName() ) );
@@ -551,12 +545,11 @@ public final class SurefireReportGenerator
     private void constructFailureDetails( Sink sink, LocalizedProperties bundle, List<ReportTestCase> failures )
     {
         sink.section1();
+        sinkAnchor( sink, "Failure_Details" );
         sink.sectionTitle1();
         sink.text( bundle.getReportLabelFailureDetails() );
         sink.sectionTitle1_();
 
-        sinkAnchor( sink, "Failure_Details" );
-
         constructHotLinks( sink, bundle );
 
         sinkLineBreak( sink );