You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Hiranya Jayathilaka (JIRA)" <ji...@apache.org> on 2009/06/09 13:46:08 UTC
[jira] Created: (WSCOMMONS-475) JMS Message Receiver Should Set the
AxisMessage when Setting the AxisOperation
JMS Message Receiver Should Set the AxisMessage when Setting the AxisOperation
------------------------------------------------------------------------------
Key: WSCOMMONS-475
URL: https://issues.apache.org/jira/browse/WSCOMMONS-475
Project: WS-Commons
Issue Type: Bug
Components: Transport
Environment: Any
Reporter: Hiranya Jayathilaka
JMSMessageReceiver in certain occasions set the AxisService and AxisOperation for incoming message contexts. But in such occasions it doesn't currently set the AxisMessage. With latest Axis2 this causes some problems when it comes to dispatching messages. This issue caused some JMS related samples to not function properly in Apache Synapse. Therefore as a simple fix we need to set the AxisMessage in JMSMessageReceiver along with the AxisOperation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WSCOMMONS-475) JMS Message Receiver Should Set
the AxisMessage when Setting the AxisOperation
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen reassigned WSCOMMONS-475:
-----------------------------------------
Assignee: Andreas Veithen
> JMS Message Receiver Should Set the AxisMessage when Setting the AxisOperation
> ------------------------------------------------------------------------------
>
> Key: WSCOMMONS-475
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-475
> Project: WS-Commons
> Issue Type: Bug
> Components: Transport
> Environment: Any
> Reporter: Hiranya Jayathilaka
> Assignee: Andreas Veithen
> Attachments: WSCOMMONS-475.patch
>
>
> JMSMessageReceiver in certain occasions set the AxisService and AxisOperation for incoming message contexts. But in such occasions it doesn't currently set the AxisMessage. With latest Axis2 this causes some problems when it comes to dispatching messages. This issue caused some JMS related samples to not function properly in Apache Synapse. Therefore as a simple fix we need to set the AxisMessage in JMSMessageReceiver along with the AxisOperation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WSCOMMONS-475) JMS Message Receiver Should Set
the AxisMessage when Setting the AxisOperation
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved WSCOMMONS-475.
---------------------------------------
Resolution: Fixed
Fix Version/s: Transports 1.0
I think it's actually the other way round: the individual transports should not have to care about how messages are dispatched, since the logic is the same for all transports (at least the type of transport implemented by AbstractTransportListener; HTTP is of course different). Moved the duplicate code to a common createMessageContext method.
> JMS Message Receiver Should Set the AxisMessage when Setting the AxisOperation
> ------------------------------------------------------------------------------
>
> Key: WSCOMMONS-475
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-475
> Project: WS-Commons
> Issue Type: Bug
> Components: Transport
> Environment: Any
> Reporter: Hiranya Jayathilaka
> Assignee: Andreas Veithen
> Fix For: Transports 1.0
>
> Attachments: WSCOMMONS-475.patch
>
>
> JMSMessageReceiver in certain occasions set the AxisService and AxisOperation for incoming message contexts. But in such occasions it doesn't currently set the AxisMessage. With latest Axis2 this causes some problems when it comes to dispatching messages. This issue caused some JMS related samples to not function properly in Apache Synapse. Therefore as a simple fix we need to set the AxisMessage in JMSMessageReceiver along with the AxisOperation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WSCOMMONS-475) JMS Message Receiver Should Set
the AxisMessage when Setting the AxisOperation
Posted by "Hiranya Jayathilaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717902#action_12717902 ]
Hiranya Jayathilaka commented on WSCOMMONS-475:
-----------------------------------------------
We could do this in base transport listener's handleIncomingRequest method but my personal opinion is that this should be handled by the individual transports. They are the ones who set the AxisService and the AxisOperation to the message context, so IMO it's really their responsibility to set the AxisMessage along with them. I've done this change for the FIX transport a few days back since some of the samples were not working properly.
> JMS Message Receiver Should Set the AxisMessage when Setting the AxisOperation
> ------------------------------------------------------------------------------
>
> Key: WSCOMMONS-475
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-475
> Project: WS-Commons
> Issue Type: Bug
> Components: Transport
> Environment: Any
> Reporter: Hiranya Jayathilaka
> Attachments: WSCOMMONS-475.patch
>
>
> JMSMessageReceiver in certain occasions set the AxisService and AxisOperation for incoming message contexts. But in such occasions it doesn't currently set the AxisMessage. With latest Axis2 this causes some problems when it comes to dispatching messages. This issue caused some JMS related samples to not function properly in Apache Synapse. Therefore as a simple fix we need to set the AxisMessage in JMSMessageReceiver along with the AxisOperation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WSCOMMONS-475) JMS Message Receiver Should Set the
AxisMessage when Setting the AxisOperation
Posted by "Hiranya Jayathilaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiranya Jayathilaka updated WSCOMMONS-475:
------------------------------------------
Attachment: WSCOMMONS-475.patch
Attaching patch
> JMS Message Receiver Should Set the AxisMessage when Setting the AxisOperation
> ------------------------------------------------------------------------------
>
> Key: WSCOMMONS-475
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-475
> Project: WS-Commons
> Issue Type: Bug
> Components: Transport
> Environment: Any
> Reporter: Hiranya Jayathilaka
> Attachments: WSCOMMONS-475.patch
>
>
> JMSMessageReceiver in certain occasions set the AxisService and AxisOperation for incoming message contexts. But in such occasions it doesn't currently set the AxisMessage. With latest Axis2 this causes some problems when it comes to dispatching messages. This issue caused some JMS related samples to not function properly in Apache Synapse. Therefore as a simple fix we need to set the AxisMessage in JMSMessageReceiver along with the AxisOperation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WSCOMMONS-475) JMS Message Receiver Should Set
the AxisMessage when Setting the AxisOperation
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WSCOMMONS-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717655#action_12717655 ]
Andreas Veithen commented on WSCOMMONS-475:
-------------------------------------------
I think we should go a step further and move the corresponding code (which seems to be copy & paste) in the FIX, VFS, JMS and mail (to be confirmed) transports to a common method in axis2-transport-base and fix it once and for all.
> JMS Message Receiver Should Set the AxisMessage when Setting the AxisOperation
> ------------------------------------------------------------------------------
>
> Key: WSCOMMONS-475
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-475
> Project: WS-Commons
> Issue Type: Bug
> Components: Transport
> Environment: Any
> Reporter: Hiranya Jayathilaka
> Attachments: WSCOMMONS-475.patch
>
>
> JMSMessageReceiver in certain occasions set the AxisService and AxisOperation for incoming message contexts. But in such occasions it doesn't currently set the AxisMessage. With latest Axis2 this causes some problems when it comes to dispatching messages. This issue caused some JMS related samples to not function properly in Apache Synapse. Therefore as a simple fix we need to set the AxisMessage in JMSMessageReceiver along with the AxisOperation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.