[GitHub] [spark] wangyum commented on a change in pull request #24534: [SPARK-27639][SQL] InMemoryTableScan shows the table name on UI if possible

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #24534: [SPARK-27639][SQL] InMemoryTableScan shows the table name on UI if possible
URL: https://github.com/apache/spark/pull/24534#discussion_r281435395
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
 ##########
 @@ -36,6 +36,15 @@ case class InMemoryTableScanExec(
     @transient relation: InMemoryRelation)
   extends LeafExecNode with ColumnarBatchScan {
 
+  override val nodeName: String = {
+    relation.cacheBuilder.tableName match {
+      case Some(tableName) =>
+        s"Scan in memory table ${tableName.replace("`", "")}"
 
 Review comment:
   How about `relation.cacheBuilder.cachedColumnBuffers.name`. Consistent with the `StorageTab`?
   ```scala
     override val nodeName: String = {
       relation.cacheBuilder.tableName match {
         case Some(_) =>
           "Scan " + relation.cacheBuilder.cachedColumnBuffers.name
         case _ =>
           super.nodeName
       }
     }
   ``` 
   ![image](https://user-images.githubusercontent.com/5399861/57265772-c6e31480-70ab-11e9-9517-089b43e26ac5.png)
   
   ![image](https://user-images.githubusercontent.com/5399861/57265991-9d76b880-70ac-11e9-9b52-f0c0a17ce1b8.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org