[GitHub] wonook commented on a change in pull request #187: [NEMO-324] Distinguish Beam's run and waitUntilFinish methods

[GitBox <gi...@apache.org>]

wonook commented on a change in pull request #187: [NEMO-324] Distinguish Beam's run and waitUntilFinish methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r249024907
 
 

 ##########
 File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/NemoPipelineResult.java
 ##########
 @@ -49,10 +60,12 @@ public State cancel() throws IOException {
 
   @Override
   public State waitUntilFinish(final Duration duration) {
-    throw new UnsupportedOperationException();
-    // TODO #208: NemoPipelineResult#waitUntilFinish hangs
-    // Previous code that hangs the job:
-    // return (State) super.waitUntilJobFinish(duration.getMillis(), TimeUnit.MILLISECONDS);
+    try {
+      this.jobDone.await();
+    } catch (final InterruptedException e) {
+      throw new RuntimeException(e);
+    }
+    return (State) super.waitUntilJobFinish(duration.getMillis(), TimeUnit.MILLISECONDS);
 
 Review comment:
   @johnyangk I'm not sure if this line actually does anything. As the original author of the code here, what do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services