[GitHub] spark pull request #17973: [SPARK-20731][SQL] Add ability to change or omit ...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17973#discussion_r116353035
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ---
    @@ -622,6 +622,31 @@ class CSVSuite extends QueryTest with SharedSQLContext with SQLTestUtils {
         }
       }
     
    +  test("save tsv with tsv suffix") {
    +    withTempDir { dir =>
    +      val csvDir = new File(dir, "csv").getCanonicalPath
    +      val cars = spark.read
    +        .format("csv")
    +        .option("header", "true")
    +        .load(testFile(carsFile))
    +
    +      cars.coalesce(1).write
    +        .option("header", "true")
    +        .option("fileExtension", ".tsv")
    +        .option("delimiter", "\t")
    --- End diff --
    
    When `delimiter` is set to `\t`, is it still a CSV? : )
    
    Ref: https://en.wikipedia.org/wiki/Tab-separated_values


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org