You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/27 08:11:03 UTC
[GitHub] [spark] maropu opened a new pull request #30157: [WIP][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
maropu opened a new pull request #30157:
URL: https://github.com/apache/spark/pull/30157
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
SPARK-30494's updated the `CreateViewCommand` code to implicitly drop cache when replacing an existing view. But, this change drops cache even when replacing a view having the same logical plan. A sequence of queries to reproduce this as follows;
```
// Spark v2.4.6+
scala> val df = spark.range(1).selectExpr("id a", "id b")
scala> df.cache()
scala> df.explain()
== Physical Plan ==
*(1) ColumnarToRow
+- InMemoryTableScan [a#2L, b#3L]
+- InMemoryRelation [a#2L, b#3L], StorageLevel(disk, memory, deserialized, 1 replicas)
+- *(1) Project [id#0L AS a#2L, id#0L AS b#3L]
+- *(1) Range (0, 1, step=1, splits=4)
scala> df.createOrReplaceTempView("t")
scala> sql("select * from t").explain()
== Physical Plan ==
*(1) ColumnarToRow
+- InMemoryTableScan [a#2L, b#3L]
+- InMemoryRelation [a#2L, b#3L], StorageLevel(disk, memory, deserialized, 1 replicas)
+- *(1) Project [id#0L AS a#2L, id#0L AS b#3L]
+- *(1) Range (0, 1, step=1, splits=4)
// If one re-runs the same query `df.createOrReplaceTempView("t")`, the cache's swept away
scala> df.createOrReplaceTempView("t")
scala> sql("select * from t").explain()
== Physical Plan ==
*(1) Project [id#0L AS a#2L, id#0L AS b#3L]
+- *(1) Range (0, 1, step=1, splits=4)
// Until v2.4.6
scala> val df = spark.range(1).selectExpr("id a", "id b")
scala> df.cache()
scala> df.createOrReplaceTempView("t")
scala> sql("select * from t").explain()
20/10/23 22:33:42 WARN ObjectStore: Failed to get database global_temp, returning NoSuchObjectException
== Physical Plan ==
*(1) InMemoryTableScan [a#2L, b#3L]
+- InMemoryRelation [a#2L, b#3L], StorageLevel(disk, memory, deserialized, 1 replicas)
+- *(1) Project [id#0L AS a#2L, id#0L AS b#3L]
+- *(1) Range (0, 1, step=1, splits=4)
scala> df.createOrReplaceTempView("t")
scala> sql("select * from t").explain()
== Physical Plan ==
*(1) InMemoryTableScan [a#2L, b#3L]
+- InMemoryRelation [a#2L, b#3L], StorageLevel(disk, memory, deserialized, 1 replicas)
+- *(1) Project [id#0L AS a#2L, id#0L AS b#3L]
+- *(1) Range (0, 1, step=1, splits=4)
```
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
bugfix.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30157: [DO-NOT-MERGE][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30157:
URL: https://github.com/apache/spark/pull/30157#issuecomment-792599084
@maropu So this is not merged to branch-2.4, right? Is it not needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30157: [DO-NOT-MERGE][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30157:
URL: https://github.com/apache/spark/pull/30157#discussion_r512811355
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UserDefinedType.scala
##########
@@ -90,7 +90,7 @@ abstract class UserDefinedType[UserType >: Null] extends DataType with Serializa
override def hashCode(): Int = getClass.hashCode()
override def equals(other: Any): Boolean = other match {
- case that: UserDefinedType[_] => this.acceptsType(that)
+ case that: UserDefinedType[_] => this.getClass == other.getClass
Review comment:
+1 for backporting. Thank you for analysis, @maropu .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30157: [WIP][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30157:
URL: https://github.com/apache/spark/pull/30157#issuecomment-717080338
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34925/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #30157: [DO-NOT-MERGE][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #30157:
URL: https://github.com/apache/spark/pull/30157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30157: [DO-NOT-MERGE][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30157:
URL: https://github.com/apache/spark/pull/30157#issuecomment-792600376
@maropu nvm, I saw the git log you committed it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30157: [WIP][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30157:
URL: https://github.com/apache/spark/pull/30157#issuecomment-717068627
**[Test build #130323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130323/testReport)** for PR 30157 at commit [`aba6916`](https://github.com/apache/spark/commit/aba6916330a76554e944d64a62a251e747f89d10).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30157: [WIP][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30157:
URL: https://github.com/apache/spark/pull/30157#issuecomment-717068627
**[Test build #130323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130323/testReport)** for PR 30157 at commit [`aba6916`](https://github.com/apache/spark/commit/aba6916330a76554e944d64a62a251e747f89d10).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30157: [DO-NOT-MERGE][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30157:
URL: https://github.com/apache/spark/pull/30157#discussion_r513101527
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UserDefinedType.scala
##########
@@ -90,7 +90,7 @@ abstract class UserDefinedType[UserType >: Null] extends DataType with Serializa
override def hashCode(): Int = getClass.hashCode()
override def equals(other: Any): Boolean = other match {
- case that: UserDefinedType[_] => this.acceptsType(that)
+ case that: UserDefinedType[_] => this.getClass == other.getClass
Review comment:
done, thanks, all!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30157: [WIP][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30157:
URL: https://github.com/apache/spark/pull/30157#issuecomment-717176359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30157: [WIP][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30157:
URL: https://github.com/apache/spark/pull/30157#issuecomment-717176359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30157: [WIP][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30157:
URL: https://github.com/apache/spark/pull/30157#discussion_r512494277
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UserDefinedType.scala
##########
@@ -90,7 +90,7 @@ abstract class UserDefinedType[UserType >: Null] extends DataType with Serializa
override def hashCode(): Int = getClass.hashCode()
override def equals(other: Any): Boolean = other match {
- case that: UserDefinedType[_] => this.acceptsType(that)
+ case that: UserDefinedType[_] => this.getClass == other.getClass
Review comment:
This update comes from https://github.com/apache/spark/commit/0ec17c989debddb56a8048e4bd29ae666e4d9c56. I'm currently checking the python test results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #30157: [DO-NOT-MERGE][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #30157:
URL: https://github.com/apache/spark/pull/30157#discussion_r512842390
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UserDefinedType.scala
##########
@@ -90,7 +90,7 @@ abstract class UserDefinedType[UserType >: Null] extends DataType with Serializa
override def hashCode(): Int = getClass.hashCode()
override def equals(other: Any): Boolean = other match {
- case that: UserDefinedType[_] => this.acceptsType(that)
+ case that: UserDefinedType[_] => this.getClass == other.getClass
Review comment:
Looks okay. Thanks for looking at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30157: [WIP][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30157:
URL: https://github.com/apache/spark/pull/30157#issuecomment-717087111
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34925/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30157: [WIP][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30157:
URL: https://github.com/apache/spark/pull/30157#issuecomment-717175802
**[Test build #130323 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130323/testReport)** for PR 30157 at commit [`aba6916`](https://github.com/apache/spark/commit/aba6916330a76554e944d64a62a251e747f89d10).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30157: [WIP][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30157:
URL: https://github.com/apache/spark/pull/30157#issuecomment-717087138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30157: [WIP][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30157:
URL: https://github.com/apache/spark/pull/30157#discussion_r512682367
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UserDefinedType.scala
##########
@@ -90,7 +90,7 @@ abstract class UserDefinedType[UserType >: Null] extends DataType with Serializa
override def hashCode(): Int = getClass.hashCode()
override def equals(other: Any): Boolean = other match {
- case that: UserDefinedType[_] => this.acceptsType(that)
+ case that: UserDefinedType[_] => this.getClass == other.getClass
Review comment:
Ah, ok. `branch-3.0` has [the same issue](https://github.com/apache/spark/runs/1307296057), but `test_infer_schema_with_udt` in `branch-3.0` does not fail because it drops the `labeled_point` view created in L350 before running the second `createOrReplaceTempView` in L361:
https://github.com/apache/spark/blob/22392be4315900346ac884ad32bd6332ffc3e64e/python/pyspark/sql/tests/test_types.py#L349-L363
A root cause of this issue is that, since `PythonUserDefinedType#userClass`is always null, `isAssignableFrom` in `UserDefinedType#acceptsType ` throws a null exception. To fix this issue, I think we need to backport https://issues.apache.org/jira/browse/SPARK-32090 into branch-3.0/2.4. WDYT? @dongjoon-hyun @viirya @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30157: [DO-NOT-MERGE][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30157:
URL: https://github.com/apache/spark/pull/30157#discussion_r513097084
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UserDefinedType.scala
##########
@@ -90,7 +90,7 @@ abstract class UserDefinedType[UserType >: Null] extends DataType with Serializa
override def hashCode(): Int = getClass.hashCode()
override def equals(other: Any): Boolean = other match {
- case that: UserDefinedType[_] => this.acceptsType(that)
+ case that: UserDefinedType[_] => this.getClass == other.getClass
Review comment:
okay, I will. Thanks for the check, @dongjoon-hyun and @viirya !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30157: [WIP][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30157:
URL: https://github.com/apache/spark/pull/30157#issuecomment-717087138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org