You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/30 04:18:13 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25614:
[WIP][SPARK-28887][K8S] Executor pod status fix
dongjoon-hyun commented on a change in pull request #25614: [WIP][SPARK-28887][K8S] Executor pod status fix
URL: https://github.com/apache/spark/pull/25614#discussion_r319351543
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodStates.scala
##########
@@ -18,20 +18,20 @@ package org.apache.spark.scheduler.cluster.k8s
import io.fabric8.kubernetes.api.model.Pod
-sealed trait ExecutorPodState {
+sealed trait ExecutorState {
Review comment:
Hi, @jinxingwang . Could you make another PR for this renaming?
This PR seems to have two orthogonal themes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org