You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2018/01/24 11:12:05 UTC

[GitHub] flink pull request #5345: [FLINK-8242] [orc] Fix predicate push-down of OrcT...

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5345#discussion_r163517596
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala ---
    @@ -214,6 +213,10 @@ class RexNodeToExpressionConverter(
             // convert to BigDecimal
             literal.getValueAs(classOf[java.math.BigDecimal])
     
    +      case _ if literal.getValue.isInstanceOf[NlsString] =>
    --- End diff --
    
    This should not be necessary because it is already done line 204. All tests are still working if I remove this change.


---