[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395764#comment-16395764 ] 

stack commented on HBASE-20178:
-------------------------------

.001 

Fail-fast by throwing exception out of Procedure constructor if
move but table is disabled, etc.
M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMove.java
 Test stolen from HBASE-20131
M hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableState.java
 Add convenience isEnabled/isDisabled
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
 Promote assert state to throw exception.
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
 Add isClusterUp
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 Move constructor now throws exception
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MoveRegionProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DisableTableProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/TruncateTableProcedure.java
 Do environment check at construction and fail-fast if hostile.
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/AbstractStateMachineTableProcedure.java
 Ad checkTableOnline utility method.
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/GCMergedRegionsProcedure.java
 Moved to procedure package.

Will probably provoke test failures. Let me see.

> [AMv2] Throw exception if hostile environment
> ---------------------------------------------
>
>                 Key: HBASE-20178
>                 URL: https://issues.apache.org/jira/browse/HBASE-20178
>             Project: HBase
>          Issue Type: Sub-task
>          Components: amv2
>            Reporter: stack
>            Priority: Major
>             Fix For: 2.0.0
>
>         Attachments: 0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch
>
>
> New pattern where we throw exception on procedure construction if cluster is going down, hosting master is stopping, table is offline, or table is read-only. Fail fast rather than later internal to Procedure so can flag caller there is a problem.
> Changed Move/Split/Merge Procedures.
> No point queuing a move region for a table that is offline and which may never be re-enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)